[PATCH-SERIES pmg-api 0/2] backup: improve error reporting

[PATCH-SERIES pmg-api 0/2] backup: improve error reporting

[Fiona Ebner]

Propagate error message from a failed Cmd::run() invocation and record
errors from tar.

This should make it easier to see what happens in bug #8095.

pmg-api:

Fiona Ebner (2):
  backup: propagate error message from failed Cmd::run() invocation
  backup: warn about errors from tar

 src/PMG/Backup.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


Summary over all repositories:
  1 files changed, 7 insertions(+), 2 deletions(-)

-- 
Generated by git-murpp 0.5.0

[PATCH pmg-api 1/2] backup: propagate error message from failed Cmd::run() invocation

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PMG/Backup.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/Backup.pm b/src/PMG/Backup.pm
index 7dbf7aa..79ca429 100644
--- a/src/PMG/Backup.pm
+++ b/src/PMG/Backup.pm
@@ -225,7 +225,7 @@ sub pmg_backup {
         push($tar_cmd->@*, $sa_configs->@*);
 
         eval { PVE::Cmd::run($tar_cmd, quiet => 1) };
-        die "unable to create system configuration backup: ERROR\n" if $@;
+        die "unable to create system configuration backup: $@" if $@;
 
         my $extradb = $include_statistics ? $statfn : '';
 
-- 
2.47.3

[PATCH pmg-api 2/2] backup: warn about errors from tar

[Fiona Ebner]

Filter out the messages about removal of leading slashes
> /bin/tar: Removing leading `/' from member names
> /bin/tar: Removing leading `/' from hard link targets
as they would appear for every backup.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PMG/Backup.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/PMG/Backup.pm b/src/PMG/Backup.pm
index 79ca429..18ceda8 100644
--- a/src/PMG/Backup.pm
+++ b/src/PMG/Backup.pm
@@ -224,7 +224,12 @@ sub pmg_backup {
 
         push($tar_cmd->@*, $sa_configs->@*);
 
-        eval { PVE::Cmd::run($tar_cmd, quiet => 1) };
+        my $errfunc = sub {
+            my ($msg) = @_;
+            return if $msg =~ m!Removing leading `/' from (member names|hard link targets)!;
+            warn "$msg\n";
+        };
+        eval { PVE::Cmd::run($tar_cmd, quiet => 1, errfunc => $errfunc) };
         die "unable to create system configuration backup: $@" if $@;
 
         my $extradb = $include_statistics ? $statfn : '';
-- 
2.47.3