[PATCH installer/proxmox 0/4] add mmcblk device support

[PATCH installer/proxmox 0/4] add mmcblk device support

[Kaiyang Wu]

This patchset adds MMC device support to the installer and displays a wear-out
warning for MMC targets per request from Fabian Grünbichler [0].

[0]: https://lore.proxmox.com/pve-devel/1754642580.9yu7vgyf68.astroid@yuna.none/

installer:

Kaiyang Wu (3):
  block: add support for MMC devices
  ui: show wear-out warning when installing on MMC devices
  tui: show wear-out warning when installing on MMC devices

 Proxmox/Sys/Block.pm              |  2 ++
 proxinstall                       |  5 +++++
 proxmox-tui-installer/src/main.rs | 25 +++++++++++++++++++++++--
 3 files changed, 30 insertions(+), 2 deletions(-)


proxmox:

Kaiyang Wu (1):
  schema: api-types: add support for MMC devices

 proxmox-schema/src/api_types.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.56.0

[PATCH installer 1/4] block: add support for MMC devices

[Kaiyang Wu]

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 Proxmox/Sys/Block.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Proxmox/Sys/Block.pm b/Proxmox/Sys/Block.pm
index 89b01c9..3d1aff4 100644
--- a/Proxmox/Sys/Block.pm
+++ b/Proxmox/Sys/Block.pm
@@ -173,6 +173,8 @@ sub get_partition_dev {
         return "${dev}$partnum";
     } elsif ($dev =~ m|^/dev/nvme\d+n\d+$|) {
         return "${dev}p$partnum";
+    } elsif ($dev =~ m|^/dev/mmcblk\d+$|) {
+        return "${dev}p$partnum";
     } else {
         die "unable to get device for partition $partnum on device $dev\n";
     }
-- 
2.56.0

[PATCH installer 2/4] ui: show wear-out warning when installing on MMC devices

[Kaiyang Wu]

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 proxinstall | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/proxinstall b/proxinstall
index 51efe79..270f6cb 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1823,6 +1823,11 @@ sub create_hdsel_view {
                 $target_hds = [$target_hd];
             }
 
+            if ($iso_env->{product} eq 'pve' && grep { m|^/dev/mmcblk\d+$| } @$target_hds) {
+                Proxmox::UI::message(
+                    "Proxmox VE is write intensive, MMC devices may wear out quickly.");
+            }
+
             $step_number++;
             create_country_view();
         },
-- 
2.56.0

[PATCH installer 3/4] tui: show wear-out warning when installing on MMC devices

[Kaiyang Wu]

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 proxmox-tui-installer/src/main.rs | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs
index e9f47a9..243457d 100644
--- a/proxmox-tui-installer/src/main.rs
+++ b/proxmox-tui-installer/src/main.rs
@@ -391,10 +391,31 @@ fn bootdisk_dialog(siv: &mut Cursive) -> InstallerView {
             match options {
                 Some(Ok(options)) => {
                     siv.with_user_data(|state: &mut InstallerState| {
-                        state.options.bootdisk = options;
+                        state.options.bootdisk = options.clone();
                     });
 
-                    switch_to_next_screen(siv, InstallerStep::Timezone, &timezone_dialog);
+                    if options
+                        .disks
+                        .iter()
+                        .fold(false, |acc, disk| acc || disk.path.contains("mmcblk"))
+                    {
+                        siv.add_layer(
+                            Dialog::text(
+                                "Proxmox VE is write intensive, MMC devices may wear out quickly.",
+                            )
+                            .title("Warning")
+                            .button("Ok", |siv| {
+                                siv.pop_layer();
+                                switch_to_next_screen(
+                                    siv,
+                                    InstallerStep::Timezone,
+                                    &timezone_dialog,
+                                );
+                            }),
+                        );
+                    } else {
+                        switch_to_next_screen(siv, InstallerStep::Timezone, &timezone_dialog);
+                    }
                 }
 
                 Some(Err(err)) => siv.add_layer(Dialog::info(format!("Invalid values: {err}"))),
-- 
2.56.0

[PATCH proxmox 4/4] schema: api-types: add support for MMC devices

[Kaiyang Wu]

Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
---
 proxmox-schema/src/api_types.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-schema/src/api_types.rs b/proxmox-schema/src/api_types.rs
index 7d3fa13c..9da0ac0a 100644
--- a/proxmox-schema/src/api_types.rs
+++ b/proxmox-schema/src/api_types.rs
@@ -123,8 +123,8 @@ const_regex! {
     /// specified in the RFC.
     pub GENERIC_URI_REGEX = r#"^[^\x00-\x1F\x7F <>#"]*$"#;
 
-    pub BLOCKDEVICE_NAME_REGEX = r"^(?:(?:h|s|x?v)d[a-z]+)|(?:nvme\d+n\d+)$";
-    pub BLOCKDEVICE_DISK_AND_PARTITION_NAME_REGEX = r"^(?:(?:h|s|x?v)d[a-z]+\d*)|(?:nvme\d+n\d+(p\d+)?)$";
+    pub BLOCKDEVICE_NAME_REGEX = r"^(?:(?:h|s|x?v)d[a-z]+)|(?:nvme\d+n\d+)|(?:mmcblk\d+)$";
+    pub BLOCKDEVICE_DISK_AND_PARTITION_NAME_REGEX = r"^(?:(?:h|s|x?v)d[a-z]+\d*)|(?:nvme\d+n\d+(p\d+)?)|(?:mmcblk\d+(p\d+)?)$";
 
     /// Regex to match a base64-encoded ED25519 key.
     /// A ED25519 key has always 32 bytes of raw key material, base64 needs 4 * (n / 3) characters
-- 
2.56.0