* [PATCH] api: aliases: make 'cidr' optional when updating
@ 2026-09-29 13:23 Arthur Bied-Charreton
2026-09-29 13:26 ` superseded: " Arthur Bied-Charreton
0 siblings, 1 reply; 2+ messages in thread
From: Arthur Bied-Charreton @ 2026-09-29 13:23 UTC (permalink / raw)
To: pve-devel
Updating an alias required passing its CIDR, even when only renaming it.
Clients therefore had to fetch the alias first just to send back the
currently configured CIDR.
Make 'cidr' optional in PUT .../firewall/aliases/{name} and keep the
existing CIDR if none is passed.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
src/PVE/API2/Firewall/Aliases.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Firewall/Aliases.pm b/src/PVE/API2/Firewall/Aliases.pm
index 4f6960d..9fd1348 100644
--- a/src/PVE/API2/Firewall/Aliases.pm
+++ b/src/PVE/API2/Firewall/Aliases.pm
@@ -215,7 +215,7 @@ sub register_update_alias {
$properties->{name} = $api_properties->{name};
$properties->{rename} = $api_properties->{rename};
- $properties->{cidr} = $api_properties->{cidr};
+ $properties->{cidr} = { $api_properties->{cidr}->%*, optional => 1 };
$properties->{comment} = $api_properties->{comment};
$properties->{digest} = get_standard_option('pve-config-digest');
@@ -251,7 +251,10 @@ sub register_update_alias {
raise_param_exc({ name => "no such alias" }) if !$aliases->{$name};
- my $data = { name => $param->{name}, cidr => $param->{cidr} };
+ my $data = {
+ name => $param->{name},
+ cidr => $param->{cidr} // $aliases->{$name}->{cidr},
+ };
$data->{comment} = $param->{comment} if $param->{comment};
$aliases->{$name} = $data;
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-29 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 13:23 [PATCH] api: aliases: make 'cidr' optional when updating Arthur Bied-Charreton
2026-09-29 13:26 ` superseded: " Arthur Bied-Charreton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.