all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change
Date: Tue, 15 Sep 2026 11:16:56 +0200	[thread overview]
Message-ID: <20260915091758.85522-1-j.theisen@proxmox.com> (raw)

To allow reuse of the same code this patch series factors out
the relevant function inside the APT part of the API and reuses
the function on change of the http_proxy variable in the Cluster API.

This is to ensure a consistent state after a change of the HTTP proxy
without having to run a Refresh / apt update through the PVE tooling.

https://bugzilla.proxmox.com/show_bug.cgi?id=8031

Changes from v2:
 * Refactored check for proxy change for more human-readability
 * Verified regex pattern

Rationale for the regex pattern's \b boundaries is that potential
new parameters could be named http_proxy_port or similar which
would still match the regex pattern without the \b boundaries.
This can be intentional but should be checked if the problem arises.

Tested:
 * Set HTTP Proxy through GUI updates apt proxy config
 * Removal of HTTP proxy through GUI updates config
 * Removal of http_proxy and bwlimit through API updates config

Thanks for the feedback @m.sandoval!

Jonas Theisen (2):
  fix #8031: factor out APT proxy write from update_database call
  fix #8031: write APT proxy config on http_proxy change

 PVE/API2/APT.pm     | 23 ++++++++++++++---------
 PVE/API2/Cluster.pm | 14 ++++++++++++++
 2 files changed, 28 insertions(+), 9 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-09-15  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  9:16 Jonas Theisen [this message]
2026-09-15  9:16 ` [PATCH pve-manager v3 1/2] fix #8031: factor out APT proxy write from update_database call Jonas Theisen
2026-09-15  9:16 ` [PATCH pve-manager v3 2/2] fix #8031: write APT proxy config on http_proxy change Jonas Theisen
2026-09-16  9:32 ` [PATCH pve-manager v3 0/2] " Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915091758.85522-1-j.theisen@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal