From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 08F3D1FF0AE for ; Tue, 15 Sep 2026 11:18:20 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4919E2156C; Tue, 15 Sep 2026 11:18:18 +0200 (CEST) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v3 0/2] fix #8031: write APT proxy config on http_proxy change Date: Tue, 15 Sep 2026 11:16:56 +0200 Message-ID: <20260915091758.85522-1-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789463872151 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.321 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SWQXP7BHDFD2HARYNCGCTHLDNC4IZSFL X-Message-ID-Hash: SWQXP7BHDFD2HARYNCGCTHLDNC4IZSFL X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: To allow reuse of the same code this patch series factors out the relevant function inside the APT part of the API and reuses the function on change of the http_proxy variable in the Cluster API. This is to ensure a consistent state after a change of the HTTP proxy without having to run a Refresh / apt update through the PVE tooling. https://bugzilla.proxmox.com/show_bug.cgi?id=8031 Changes from v2: * Refactored check for proxy change for more human-readability * Verified regex pattern Rationale for the regex pattern's \b boundaries is that potential new parameters could be named http_proxy_port or similar which would still match the regex pattern without the \b boundaries. This can be intentional but should be checked if the problem arises. Tested: * Set HTTP Proxy through GUI updates apt proxy config * Removal of HTTP proxy through GUI updates config * Removal of http_proxy and bwlimit through API updates config Thanks for the feedback @m.sandoval! Jonas Theisen (2): fix #8031: factor out APT proxy write from update_database call fix #8031: write APT proxy config on http_proxy change PVE/API2/APT.pm | 23 ++++++++++++++--------- PVE/API2/Cluster.pm | 14 ++++++++++++++ 2 files changed, 28 insertions(+), 9 deletions(-) -- 2.47.3