all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional
Date: Fri,  4 Sep 2026 11:17:45 +0200	[thread overview]
Message-ID: <20260904091747.73474-1-g.goller@proxmox.com> (raw)

The hostname is optional, it is usually passed on BGP Open, but that
doesn't have to be. Even though we always use the ip and not the
hostname, this can make parsing fail.

See:
https://github.com/FRRouting/frr/blob/b8316e31cb8b7caeed43ce363b0616e15a2acf15/bgpd/bgp_vty.c#L14674

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 proxmox-frr/src/de/evpn.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-frr/src/de/evpn.rs b/proxmox-frr/src/de/evpn.rs
index 942aecf367ee..ea67c7cc9497 100644
--- a/proxmox-frr/src/de/evpn.rs
+++ b/proxmox-frr/src/de/evpn.rs
@@ -98,7 +98,7 @@ pub struct Nexthop {
     /// IP of the nexthop
     pub ip: IpAddr,
     /// Hostname of the nexthop
-    pub hostname: String,
+    pub hostname: Option<String>,
     /// Afi of the ip
     pub afi: Option<Protocol>,
     /// Used
-- 
2.47.3





                 reply	other threads:[~2026-09-04  9:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904091747.73474-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal