From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 41C2F1FF0A5 for ; Fri, 04 Sep 2026 11:17:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0B69D214F5; Fri, 04 Sep 2026 11:17:56 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH ve-rs] fix #8008: frr: make l2 route nexthop hostname optional Date: Fri, 4 Sep 2026 11:17:45 +0200 Message-ID: <20260904091747.73474-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788513467611 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.323 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LD7VCHMHBH537B5XGWF3EIXWZTFEPTVX X-Message-ID-Hash: LD7VCHMHBH537B5XGWF3EIXWZTFEPTVX X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The hostname is optional, it is usually passed on BGP Open, but that doesn't have to be. Even though we always use the ip and not the hostname, this can make parsing fail. See: https://github.com/FRRouting/frr/blob/b8316e31cb8b7caeed43ce363b0616e15a2acf15/bgpd/bgp_vty.c#L14674 Signed-off-by: Gabriel Goller --- proxmox-frr/src/de/evpn.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-frr/src/de/evpn.rs b/proxmox-frr/src/de/evpn.rs index 942aecf367ee..ea67c7cc9497 100644 --- a/proxmox-frr/src/de/evpn.rs +++ b/proxmox-frr/src/de/evpn.rs @@ -98,7 +98,7 @@ pub struct Nexthop { /// IP of the nexthop pub ip: IpAddr, /// Hostname of the nexthop - pub hostname: String, + pub hostname: Option, /// Afi of the ip pub afi: Option, /// Used -- 2.47.3