all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox_login_manager 1/1] cleanup: remove print statements
Date: Fri, 21 Aug 2026 15:07:17 +0200	[thread overview]
Message-ID: <20260821130718.330515-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260821130718.330515-1-s.shaji@proxmox.com>

Dart linter rules recommend avoiding print statements [0]. To align with
this, remove all print statements.

- [0] https://dart.dev/tools/linter-rules/avoid_print

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 analysis_options.yaml       | 1 -
 lib/proxmox_login_form.dart | 5 +----
 lib/proxmox_tfa_form.dart   | 4 +---
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/analysis_options.yaml b/analysis_options.yaml
index cd3b168..3e5d916 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -22,7 +22,6 @@ linter:
   # `// ignore_for_file: name_of_lint` syntax on the line or in the file
   # producing the lint.
   rules:
-    avoid_print: false  # Uncomment to disable the `avoid_print` rule
     # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
 
 # Additional information about this file can be found at
diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index 5b9a64e..1476930 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -571,7 +571,6 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
         Navigator.of(context).pop(client);
       }
     } on proxclient.ProxmoxApiException catch (e) {
-      print(e);
       if (!mounted) return;
       if (e.message.contains('No ticket')) {
         showDialog(
@@ -596,9 +595,7 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
           ),
         );
       }
-    } catch (e, trace) {
-      print(e);
-      print(trace);
+    } catch (e) {
       if (mounted) {
         if (e.runtimeType == HandshakeException) {
           showDialog(
diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart
index 79273fa..f9051c5 100644
--- a/lib/proxmox_tfa_form.dart
+++ b/lib/proxmox_tfa_form.dart
@@ -166,9 +166,7 @@ class _ProxmoxTfaFormState extends State<ProxmoxTfaForm> {
           ),
         );
       }
-    } catch (e, trace) {
-      print(e);
-      print(trace);
+    } catch (e) {
       if (mounted) {
         showDialog(
           context: context,
-- 
2.47.3





  parent reply	other threads:[~2026-08-21 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 13:07 [PATCH proxmox{_login_manager,_dart_api_client}/pve_flutter_frontend 0/3] cleanup: enable avoid_print Linter rule Shan Shaji
2026-08-21 13:07 ` [PATCH pve_flutter_frontend 1/1] cleanup: remove print statements Shan Shaji
2026-08-21 13:07 ` Shan Shaji [this message]
2026-08-21 13:07 ` [PATCH proxmox_dart_api_client 1/1] cleanup: avoid " Shan Shaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821130718.330515-3-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal