From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 03F831FF0AA for ; Fri, 21 Aug 2026 15:07:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 58A7721606; Fri, 21 Aug 2026 15:07:40 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox_login_manager 1/1] cleanup: remove print statements Date: Fri, 21 Aug 2026 15:07:17 +0200 Message-ID: <20260821130718.330515-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260821130718.330515-1-s.shaji@proxmox.com> References: <20260821130718.330515-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787317620762 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.570 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MIR2G44ZY3X32E6JHPMFNN7U5H5ERMTO X-Message-ID-Hash: MIR2G44ZY3X32E6JHPMFNN7U5H5ERMTO X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dart linter rules recommend avoiding print statements [0]. To align with this, remove all print statements. - [0] https://dart.dev/tools/linter-rules/avoid_print Signed-off-by: Shan Shaji --- analysis_options.yaml | 1 - lib/proxmox_login_form.dart | 5 +---- lib/proxmox_tfa_form.dart | 4 +--- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index cd3b168..3e5d916 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -22,7 +22,6 @@ linter: # `// ignore_for_file: name_of_lint` syntax on the line or in the file # producing the lint. rules: - avoid_print: false # Uncomment to disable the `avoid_print` rule # prefer_single_quotes: true # Uncomment to enable the `prefer_single_quotes` rule # Additional information about this file can be found at diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index 5b9a64e..1476930 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -571,7 +571,6 @@ class _ProxmoxLoginPageState extends State { Navigator.of(context).pop(client); } } on proxclient.ProxmoxApiException catch (e) { - print(e); if (!mounted) return; if (e.message.contains('No ticket')) { showDialog( @@ -596,9 +595,7 @@ class _ProxmoxLoginPageState extends State { ), ); } - } catch (e, trace) { - print(e); - print(trace); + } catch (e) { if (mounted) { if (e.runtimeType == HandshakeException) { showDialog( diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart index 79273fa..f9051c5 100644 --- a/lib/proxmox_tfa_form.dart +++ b/lib/proxmox_tfa_form.dart @@ -166,9 +166,7 @@ class _ProxmoxTfaFormState extends State { ), ); } - } catch (e, trace) { - print(e); - print(trace); + } catch (e) { if (mounted) { showDialog( context: context, -- 2.47.3