all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu 2/5] add patch to work around broken input cleanup feature in libspice-server1
Date: Thu, 13 Aug 2026 17:55:38 +0200	[thread overview]
Message-ID: <20260813155642.370461-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260813155642.370461-1-f.ebner@proxmox.com>

Cleanup for spice during QEMU shutdown was newly added in QEMU 11.1
with commit 73ae0be3f1 ("ui/spice: add cleanup on shutdown"). However,
removing inputs is broken in the libspice-server1 library. A fix is
currently only available in git master, but not part of any released
version (the current one is 0.16.0). The libspice-server1 version in
Trixie is 0.15.2-1+b1. Continue skipping the broken part of the
cleanup for now.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 ...rk-around-broken-input-cleanup-in-li.patch | 37 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 38 insertions(+)
 create mode 100644 debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch

diff --git a/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch b/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch
new file mode 100644
index 0000000000..a3bd31826d
--- /dev/null
+++ b/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch
@@ -0,0 +1,37 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Fiona Ebner <f.ebner@proxmox.com>
+Date: Thu, 13 Aug 2026 17:24:32 +0200
+Subject: [PATCH] ui/spice-core: work around broken input cleanup in
+ libspice-server1 <= 0.16.0
+
+Removing the inputs requires libspice-server1 with commit c3efe69e
+("inputs: Fix keyboard and mouse state leaks on interface removal"),
+which is not part of any released version at the time of this writing.
+Cleanup for spice during QEMU shutdown was newly added in QEMU 11.1
+and did not happen at all in the past. Continue skipping the broken
+part for now.
+
+Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
+---
+ ui/spice-core.c | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+diff --git a/ui/spice-core.c b/ui/spice-core.c
+index a0393e4ba8..182c4d0485 100644
+--- a/ui/spice-core.c
++++ b/ui/spice-core.c
+@@ -1023,7 +1023,13 @@ static void qemu_spice_cleanup(void)
+     }
+ 
+     qemu_spice_display_cleanup();
+-    qemu_spice_input_cleanup();
++    /*
++     * Removing the inputs requires libspice-server1 with commit c3efe69e ("inputs: Fix keyboard and
++     * mouse state leaks on interface removal"), which is not part of any released version at the
++     * time of this writing. Cleanup here was newly added in QEMU 11.1 and did not happen at all in
++     * the past. Continue skipping the broken part for now.
++     */
++    //qemu_spice_input_cleanup();
+     migration_remove_notifier(&migration_state);
+     g_clear_pointer(&spice_consoles, g_slist_free);
+     g_clear_pointer(&auth_passwd, g_free);
diff --git a/debian/patches/series b/debian/patches/series
index fcd92bb951..adb5606cc8 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -52,3 +52,4 @@ pve/0041-PVE-backup-get-device-info-allow-caller-to-specify-f.patch
 pve/0042-PVE-backup-implement-backup-access-setup-and-teardow.patch
 pve/0043-PVE-backup-prepare-for-the-switch-to-using-blockdev-.patch
 pve/0044-savevm-async-reuse-migration-blocker-check-for-snaps.patch
+pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch
-- 
2.47.3





  parent reply	other threads:[~2026-08-13 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 15:55 [PATCH-SERIES qemu/qemu-server 0/5] QEMU 11.1.0 Fiona Ebner
2026-08-13 15:55 ` [PATCH qemu 1/5] update submodule and patches to " Fiona Ebner
2026-08-13 15:55 ` Fiona Ebner [this message]
2026-08-13 15:55 ` [PATCH qemu 3/5] bump version to 11.1.0-1 Fiona Ebner
2026-08-13 15:55 ` [PATCH qemu-server 4/5] monitor: use new QOM syntax on the QEMU commandline for monitor objects Fiona Ebner
2026-08-13 15:55 ` [PATCH qemu-server 5/5] d/control: bump versioned build dependency for pve-qemu-kvm Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813155642.370461-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal