From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 390221FF0EA for ; Thu, 13 Aug 2026 17:57:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3F85A219A3; Thu, 13 Aug 2026 17:56:50 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu 2/5] add patch to work around broken input cleanup feature in libspice-server1 Date: Thu, 13 Aug 2026 17:55:38 +0200 Message-ID: <20260813155642.370461-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813155642.370461-1-f.ebner@proxmox.com> References: <20260813155642.370461-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786636588739 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JZRRVIWI22D2NECXZRBDAI4FNC6NPXCR X-Message-ID-Hash: JZRRVIWI22D2NECXZRBDAI4FNC6NPXCR X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Cleanup for spice during QEMU shutdown was newly added in QEMU 11.1 with commit 73ae0be3f1 ("ui/spice: add cleanup on shutdown"). However, removing inputs is broken in the libspice-server1 library. A fix is currently only available in git master, but not part of any released version (the current one is 0.16.0). The libspice-server1 version in Trixie is 0.15.2-1+b1. Continue skipping the broken part of the cleanup for now. Signed-off-by: Fiona Ebner --- ...rk-around-broken-input-cleanup-in-li.patch | 37 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 38 insertions(+) create mode 100644 debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch diff --git a/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch b/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch new file mode 100644 index 0000000000..a3bd31826d --- /dev/null +++ b/debian/patches/pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch @@ -0,0 +1,37 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Fiona Ebner +Date: Thu, 13 Aug 2026 17:24:32 +0200 +Subject: [PATCH] ui/spice-core: work around broken input cleanup in + libspice-server1 <= 0.16.0 + +Removing the inputs requires libspice-server1 with commit c3efe69e +("inputs: Fix keyboard and mouse state leaks on interface removal"), +which is not part of any released version at the time of this writing. +Cleanup for spice during QEMU shutdown was newly added in QEMU 11.1 +and did not happen at all in the past. Continue skipping the broken +part for now. + +Signed-off-by: Fiona Ebner +--- + ui/spice-core.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/ui/spice-core.c b/ui/spice-core.c +index a0393e4ba8..182c4d0485 100644 +--- a/ui/spice-core.c ++++ b/ui/spice-core.c +@@ -1023,7 +1023,13 @@ static void qemu_spice_cleanup(void) + } + + qemu_spice_display_cleanup(); +- qemu_spice_input_cleanup(); ++ /* ++ * Removing the inputs requires libspice-server1 with commit c3efe69e ("inputs: Fix keyboard and ++ * mouse state leaks on interface removal"), which is not part of any released version at the ++ * time of this writing. Cleanup here was newly added in QEMU 11.1 and did not happen at all in ++ * the past. Continue skipping the broken part for now. ++ */ ++ //qemu_spice_input_cleanup(); + migration_remove_notifier(&migration_state); + g_clear_pointer(&spice_consoles, g_slist_free); + g_clear_pointer(&auth_passwd, g_free); diff --git a/debian/patches/series b/debian/patches/series index fcd92bb951..adb5606cc8 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -52,3 +52,4 @@ pve/0041-PVE-backup-get-device-info-allow-caller-to-specify-f.patch pve/0042-PVE-backup-implement-backup-access-setup-and-teardow.patch pve/0043-PVE-backup-prepare-for-the-switch-to-using-blockdev-.patch pve/0044-savevm-async-reuse-migration-blocker-check-for-snaps.patch +pve/0045-ui-spice-core-work-around-broken-input-cleanup-in-li.patch -- 2.47.3