all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Enrico Plantulli <plantulli@gmail.com>
To: pbs-devel@lists.proxmox.com
Cc: Enrico Plantulli <plantulli@gmail.com>
Subject: [PATCH v2 proxmox-backup 3/3] ui: tuning: add GC chunk metadata prefetch options
Date: Tue, 11 Aug 2026 11:37:21 +0200	[thread overview]
Message-ID: <20260811093722.735290-4-plantulli@gmail.com> (raw)
In-Reply-To: <20260811093722.735290-1-plantulli@gmail.com>

The datastore option view rebuilds the tuning property string from
the fields of the form, so a tuning option without a field is dropped
as soon as any other tuning option is edited in the GUI. Add the
fields for gc-chunk-metadata-prefetch and gc-prefetch-batch-size, and
render them explicitly in the summary.

Signed-off-by: Enrico Plantulli <plantulli@gmail.com>
---
 www/Utils.js                | 12 ++++++++++++
 www/datastore/OptionView.js | 27 +++++++++++++++++++++++++++
 2 files changed, 39 insertions(+)

diff --git a/www/Utils.js b/www/Utils.js
index d6bfd45..014d0c9 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -923,6 +923,18 @@ Ext.define('PBS.Utils', {
             `${gettext('GC cache capacity')}: ${gc_cache_capacity ?? Proxmox.Utils.defaultText}`,
         );
 
+        let gc_chunk_metadata_prefetch = tuning['gc-chunk-metadata-prefetch'];
+        delete tuning['gc-chunk-metadata-prefetch'];
+        options.push(
+            `${gettext('GC chunk metadata prefetch')}: ${gc_chunk_metadata_prefetch ?? false}`,
+        );
+
+        let gc_prefetch_batch_size = tuning['gc-prefetch-batch-size'];
+        delete tuning['gc-prefetch-batch-size'];
+        options.push(
+            `${gettext('GC prefetch batch size')}: ${gc_prefetch_batch_size ?? Proxmox.Utils.defaultText}`,
+        );
+
         let verification_workers = tuning['default-verification-workers'];
         delete tuning['default-verification-workers'];
         options.push(`${gettext('Default verification workers')}: ${verification_workers ?? 4}`);
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 42a6104..5d3e476 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -338,6 +338,33 @@ Ext.define('PBS.Datastore.Options', {
                             deleteEmpty: true,
                             step: 1024,
                         },
+                        {
+                            xtype: 'proxmoxcheckbox',
+                            name: 'gc-chunk-metadata-prefetch',
+                            fieldLabel: gettext('GC Chunk Metadata Prefetch'),
+                            labelWidth: 200,
+                            autoEl: {
+                                tag: 'div',
+                                'data-qtip': gettext(
+                                    'Defer and batch chunk atime updates in GC phase 1 to load chunk metadata in bulk',
+                                ),
+                            },
+                            value: 0,
+                            uncheckedValue: 0,
+                            defaultValue: 0,
+                            deleteDefaultValue: true,
+                        },
+                        {
+                            xtype: 'proxmoxintegerfield',
+                            name: 'gc-prefetch-batch-size',
+                            fieldLabel: gettext('GC Prefetch Batch Size'),
+                            labelWidth: 200,
+                            emptyText: '1048576',
+                            minValue: 1024,
+                            maxValue: 16 * 1024 * 1024,
+                            deleteEmpty: true,
+                            step: 1024,
+                        },
                         {
                             xtype: 'proxmoxintegerfield',
                             name: 'default-verification-readers',
-- 
2.47.3




  parent reply	other threads:[~2026-08-11  9:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  5:01 [PATCH proxmox proxmox-backup 0/3] datastore: gc: prefetch chunk metadata before phase 1 Enrico Plantulli
2026-08-10  5:01 ` [PATCH proxmox 1/3] pbs-api-types: add gc chunk metadata prefetch tuning option Enrico Plantulli
2026-08-10  5:01 ` [PATCH proxmox-backup 2/3] datastore: gc: optionally prefetch chunk metadata before phase 1 Enrico Plantulli
2026-08-10 10:19   ` Christian Ebner
2026-08-10 15:05     ` Enrico Plantulli
2026-08-10  5:02 ` [PATCH proxmox-backup 3/3] ui: tuning: add GC chunk metadata prefetch option Enrico Plantulli
2026-08-10 10:13 ` [PATCH proxmox proxmox-backup 0/3] datastore: gc: prefetch chunk metadata before phase 1 Christian Ebner
2026-08-10 20:32   ` Enrico Plant
2026-08-11  8:23     ` Christian Ebner
2026-08-11  9:37 ` [PATCH v2 proxmox proxmox-backup 0/3] datastore: gc: defer and batch chunk atime updates Enrico Plantulli
2026-08-11  9:37   ` [PATCH v2 proxmox 1/3] pbs-api-types: add gc chunk metadata prefetch tuning options Enrico Plantulli
2026-08-14 14:34     ` Christian Ebner
2026-08-11  9:37   ` [PATCH v2 proxmox-backup 2/3] datastore: gc: optionally defer and batch chunk atime updates Enrico Plantulli
2026-08-14 14:34     ` Christian Ebner
2026-08-11  9:37   ` Enrico Plantulli [this message]
2026-08-14 14:48   ` [PATCH v2 proxmox proxmox-backup 0/3] datastore: gc: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811093722.735290-4-plantulli@gmail.com \
    --to=plantulli@gmail.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal