From: Enrico Plantulli <plantulli@gmail.com>
To: pbs-devel@lists.proxmox.com
Cc: Enrico Plantulli <plantulli@gmail.com>
Subject: [PATCH proxmox-backup 3/3] ui: tuning: add GC chunk metadata prefetch option
Date: Mon, 10 Aug 2026 07:02:00 +0200 [thread overview]
Message-ID: <20260810050201.347124-4-plantulli@gmail.com> (raw)
In-Reply-To: <20260810050201.347124-1-plantulli@gmail.com>
The datastore option view rebuilds the tuning property string from the
fields of the form, so a tuning option that has no field is dropped as
soon as any other tuning option is edited in the GUI. Add the field for
gc-chunk-metadata-prefetch, and render it explicitly in the summary
instead of letting it fall through to the generic loop.
Signed-off-by: Enrico Plantulli <plantulli@gmail.com>
---
www/Utils.js | 6 ++++++
www/datastore/OptionView.js | 16 ++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/www/Utils.js b/www/Utils.js
index d6bfd45..d09e02d 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -923,6 +923,12 @@ Ext.define('PBS.Utils', {
`${gettext('GC cache capacity')}: ${gc_cache_capacity ?? Proxmox.Utils.defaultText}`,
);
+ let gc_chunk_metadata_prefetch = tuning['gc-chunk-metadata-prefetch'];
+ delete tuning['gc-chunk-metadata-prefetch'];
+ options.push(
+ `${gettext('GC chunk metadata prefetch')}: ${gc_chunk_metadata_prefetch ?? false}`,
+ );
+
let verification_workers = tuning['default-verification-workers'];
delete tuning['default-verification-workers'];
options.push(`${gettext('Default verification workers')}: ${verification_workers ?? 4}`);
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 42a6104..a385633 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -338,6 +338,22 @@ Ext.define('PBS.Datastore.Options', {
deleteEmpty: true,
step: 1024,
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'gc-chunk-metadata-prefetch',
+ fieldLabel: gettext('GC Chunk Metadata Prefetch'),
+ labelWidth: 200,
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext(
+ 'Iterate chunk directories before GC phase 1 to load chunk metadata in bulk',
+ ),
+ },
+ value: 0,
+ uncheckedValue: 0,
+ defaultValue: 0,
+ deleteDefaultValue: true,
+ },
{
xtype: 'proxmoxintegerfield',
name: 'default-verification-readers',
--
2.47.3
next prev parent reply other threads:[~2026-08-10 5:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 5:01 [PATCH proxmox proxmox-backup 0/3] datastore: gc: prefetch chunk metadata before phase 1 Enrico Plantulli
2026-08-10 5:01 ` [PATCH proxmox 1/3] pbs-api-types: add gc chunk metadata prefetch tuning option Enrico Plantulli
2026-08-10 5:01 ` [PATCH proxmox-backup 2/3] datastore: gc: optionally prefetch chunk metadata before phase 1 Enrico Plantulli
2026-08-10 10:19 ` Christian Ebner
2026-08-10 15:05 ` Enrico Plantulli
2026-08-10 5:02 ` Enrico Plantulli [this message]
2026-08-10 10:13 ` [PATCH proxmox proxmox-backup 0/3] datastore: gc: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810050201.347124-4-plantulli@gmail.com \
--to=plantulli@gmail.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.