[RFC pve-manager 24/27] ui: san luns: show multipath path state

[Dietmar Maurer <dietmar@proxmox.com>]

Render the active path count next to the total and prepend a warning
icon when they differ, so a degraded multipath device stands out. A
row expander shows the member paths with their state and, depending
on the multipath stack, checker state and WWPNs (multipathd) or ANA
state and controller address (native NVMe multipath), plus the fault
counter, which would otherwise require "multipath -ll" or digging
through sysfs on the CLI. The FC storage wizard LUN grid picks up
the degraded hint through the shared renderer.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 www/manager6/Utils.js        | 12 +++++-
 www/manager6/node/SANLuns.js | 74 ++++++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+), 1 deletion(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 5972e1aa..a34e1363 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1102,7 +1102,17 @@ Ext.define('PVE.Utils', {
             // only multipath mapped devices report their path count
             let paths = rec.get('paths');
             if (paths) {
-                text += ` (${paths} ${ngettext('path', 'paths', paths)})`;
+                let active = rec.get('active-paths');
+                if (Ext.isNumeric(active) && active < paths) {
+                    let qtip = Ext.htmlEncode(
+                        gettext('Some paths failed, the multipath device is degraded'),
+                    );
+                    text =
+                        `<i data-qtip="${qtip}" class="fa fa-exclamation-triangle warning"></i> ` +
+                        `${text} (${active}/${paths} ${gettext('paths')})`;
+                } else {
+                    text += ` (${paths} ${ngettext('path', 'paths', paths)})`;
+                }
             }
             return text;
         },
diff --git a/www/manager6/node/SANLuns.js b/www/manager6/node/SANLuns.js
index b2b9e24d..ce11c39b 100644
--- a/www/manager6/node/SANLuns.js
+++ b/www/manager6/node/SANLuns.js
@@ -15,6 +15,77 @@ Ext.define('PVE.node.SANLunList', {
         trackOver: false,
     },
 
+    plugins: [
+        {
+            ptype: 'rowexpander',
+            expandOnDblClick: false,
+            scrollIntoViewOnExpand: false,
+            rowBodyTpl: [
+                '{[this.renderDetails(values)]}',
+                {
+                    renderDetails: function (values) {
+                        let enc = Ext.htmlEncode;
+                        let lines = [];
+                        if (values.wwn) {
+                            lines.push(`<b>WWN:</b> ${enc(values.wwn)}`);
+                        }
+                        if (values.serial) {
+                            lines.push(`<b>${gettext('Serial')}:</b> ${enc(values.serial)}`);
+                        }
+                        let faults = values['path-faults'];
+                        if (Ext.isNumeric(faults)) {
+                            lines.push(
+                                `<b>${gettext('Path Failures Since Map Creation')}:</b> ${enc(faults)}`,
+                            );
+                        }
+                        let paths = values['path-list'] || [];
+                        if (paths.length) {
+                            // multipathd paths report checker state and WWPNs, NVMe
+                            // paths their ANA state and controller address
+                            let goodStates = { active: 1, live: 1 };
+                            let goodAna = { optimized: 1, 'non-optimized': 1 };
+                            let columns = [
+                                { key: 'device', label: gettext('Path') },
+                                {
+                                    key: 'state',
+                                    label: gettext('State'),
+                                    bad: (path) => !goodStates[path.state],
+                                },
+                                { key: 'checker-state', label: gettext('Checker') },
+                                {
+                                    key: 'ana-state',
+                                    label: 'ANA',
+                                    bad: (path) => !goodAna[path['ana-state']],
+                                },
+                                { key: 'host-wwpn', label: 'Host WWPN' },
+                                { key: 'target-wwpn', label: 'Target WWPN' },
+                                { key: 'address', label: gettext('Address') },
+                            ].filter((col) => paths.some((path) => path[col.key] !== undefined));
+                            let header = columns
+                                .map((col) => `<th style="text-align: left;">${col.label}</th>`)
+                                .join('');
+                            let rows = paths.map((path) => {
+                                let cells = columns.map((col) => {
+                                    let text = enc(path[col.key] ?? '');
+                                    if (text !== '' && col.bad && col.bad(path)) {
+                                        text = `<i class="fa fa-exclamation-triangle warning"></i> ${text}`;
+                                    }
+                                    return text;
+                                });
+                                return `<tr><td>${cells.join('</td><td>')}</td></tr>`;
+                            });
+                            lines.push(
+                                `<table style="border-spacing: 10px 2px;">` +
+                                    `<tr>${header}</tr>${rows.join('')}</table>`,
+                            );
+                        }
+                        return lines.join('<br>');
+                    },
+                },
+            ],
+        },
+    ],
+
     columns: [
         {
             header: gettext('Device'),
@@ -105,6 +176,9 @@ Ext.define('PVE.node.SANLunList', {
                 'serial',
                 'wwn',
                 'paths',
+                'active-paths',
+                'path-faults',
+                'path-list',
                 'usage',
                 'vgname',
                 'used-by-storage',
-- 
2.47.3