all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager v4 5/6] ui: sdn: remove IPv6 forwarding hint from fabric edit window
Date: Mon, 27 Jul 2026 15:55:06 +0200	[thread overview]
Message-ID: <20260727135509.14588-6-l.sichert@proxmox.com> (raw)
In-Reply-To: <20260727135509.14588-1-l.sichert@proxmox.com>

The fabric edit window warned users to enable global IPv6 forwarding
when configuring an IPv6 fabric prefix. This is no longer required, as
the SDN backend now enables per-interface IPv6 forwarding where needed
via force_forwarding.

Remove the hint to avoid suggesting the broader host-wide sysctl
setting, which can disable Router Advertisements on the host.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 www/manager6/sdn/fabrics/FabricEdit.js | 59 +++++++++-----------------
 1 file changed, 20 insertions(+), 39 deletions(-)

diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index e9e0d1fa..a8c71785 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -13,12 +13,6 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
 
     baseUrl: '/cluster/sdn/fabrics/fabric',
 
-    viewModel: {
-        data: {
-            showIpv6ForwardingHint: false,
-        },
-    },
-
     items: [
         {
             xtype: 'textfield',
@@ -83,42 +77,29 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
         }
 
         if (me.hasIpv6Support) {
-            me.items.push(
-                {
-                    xtype: 'displayfield',
-                    value: 'To make IPv6 fabrics work, enable global IPv6 forwarding on all nodes. Click on the Help button for more details.',
-                    bind: {
-                        hidden: '{!showIpv6ForwardingHint}',
-                    },
-                    userCls: 'pmx-hint',
+            me.items.push({
+                xtype: 'proxmoxtextfield',
+                fieldLabel: gettext('IPv6 Prefix'),
+                labelWidth: 120,
+                name: 'ip6_prefix',
+                disabled: me.disableIpPrefixEdit,
+                allowBlank: true,
+                vtype: 'IP6CIDRAddress',
+                skipEmptyText: true,
+                deleteEmpty: !me.isCreate,
+                validator: function (value) {
+                    let ipPrefix = this.up('window').down('[name=ip_prefix]')?.getValue();
+                    if (value || ipPrefix) {
+                        return true;
+                    }
+                    return gettext('Either IPv4 Prefix or IPv6 Prefix is required');
                 },
-                {
-                    xtype: 'proxmoxtextfield',
-                    fieldLabel: gettext('IPv6 Prefix'),
-                    labelWidth: 120,
-                    name: 'ip6_prefix',
-                    disabled: me.disableIpPrefixEdit,
-                    allowBlank: true,
-                    vtype: 'IP6CIDRAddress',
-                    skipEmptyText: true,
-                    deleteEmpty: !me.isCreate,
-                    validator: function (value) {
-                        let ipPrefix = this.up('window').down('[name=ip_prefix]')?.getValue();
-                        if (value || ipPrefix) {
-                            return true;
-                        }
-                        return gettext('Either IPv4 Prefix or IPv6 Prefix is required');
-                    },
-                    listeners: {
-                        change: function (textbox, value) {
-                            let win = textbox.up('window');
-                            let vm = win.getViewModel();
-                            vm.set('showIpv6ForwardingHint', !!value);
-                            win.down('[name=ip_prefix]')?.validate();
-                        },
+                listeners: {
+                    change: function (textbox) {
+                        textbox.up('window').down('[name=ip_prefix]')?.validate();
                     },
                 },
-            );
+            });
         }
 
         if (me.additionalTabs.length > 0) {
-- 
2.47.3





  parent reply	other threads:[~2026-07-27 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 13:55 [PATCH docs/manager/network/perl-rs v4 0/6] sdn: enable force_forwarding for ipv6 forwarding Lukas Sichert
2026-07-27 13:55 ` [PATCH network v4 1/6] sdn: evpn: enable force_forwarding for ipv6 forwarding to subnets Lukas Sichert
2026-07-27 13:55 ` [PATCH network v4 2/6] sdn: simple: " Lukas Sichert
2026-07-27 13:55 ` [PATCH perl-rs v4 3/6] fabrics: openfabric: enable force_forwarding for ipv6 transit traffic Lukas Sichert
2026-07-27 13:55 ` [PATCH perl-rs v4 4/6] fabrics: bgp: " Lukas Sichert
2026-07-27 13:55 ` Lukas Sichert [this message]
2026-07-27 13:55 ` [PATCH docs v4 6/6] sdn: drop global ipv6 forwarding workaround from OpenFabric docs Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727135509.14588-6-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal