From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D217D1FF0ED for ; Mon, 27 Jul 2026 15:56:02 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 113902153D; Mon, 27 Jul 2026 15:55:51 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager v4 5/6] ui: sdn: remove IPv6 forwarding hint from fabric edit window Date: Mon, 27 Jul 2026 15:55:06 +0200 Message-ID: <20260727135509.14588-6-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260727135509.14588-1-l.sichert@proxmox.com> References: <20260727135509.14588-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785160483536 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7HDTD7KYEIQ5PNBW2ZAJ5VLCOZPNS43M X-Message-ID-Hash: 7HDTD7KYEIQ5PNBW2ZAJ5VLCOZPNS43M X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The fabric edit window warned users to enable global IPv6 forwarding when configuring an IPv6 fabric prefix. This is no longer required, as the SDN backend now enables per-interface IPv6 forwarding where needed via force_forwarding. Remove the hint to avoid suggesting the broader host-wide sysctl setting, which can disable Router Advertisements on the host. Signed-off-by: Lukas Sichert --- www/manager6/sdn/fabrics/FabricEdit.js | 59 +++++++++----------------- 1 file changed, 20 insertions(+), 39 deletions(-) diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js index e9e0d1fa..a8c71785 100644 --- a/www/manager6/sdn/fabrics/FabricEdit.js +++ b/www/manager6/sdn/fabrics/FabricEdit.js @@ -13,12 +13,6 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { baseUrl: '/cluster/sdn/fabrics/fabric', - viewModel: { - data: { - showIpv6ForwardingHint: false, - }, - }, - items: [ { xtype: 'textfield', @@ -83,42 +77,29 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { } if (me.hasIpv6Support) { - me.items.push( - { - xtype: 'displayfield', - value: 'To make IPv6 fabrics work, enable global IPv6 forwarding on all nodes. Click on the Help button for more details.', - bind: { - hidden: '{!showIpv6ForwardingHint}', - }, - userCls: 'pmx-hint', + me.items.push({ + xtype: 'proxmoxtextfield', + fieldLabel: gettext('IPv6 Prefix'), + labelWidth: 120, + name: 'ip6_prefix', + disabled: me.disableIpPrefixEdit, + allowBlank: true, + vtype: 'IP6CIDRAddress', + skipEmptyText: true, + deleteEmpty: !me.isCreate, + validator: function (value) { + let ipPrefix = this.up('window').down('[name=ip_prefix]')?.getValue(); + if (value || ipPrefix) { + return true; + } + return gettext('Either IPv4 Prefix or IPv6 Prefix is required'); }, - { - xtype: 'proxmoxtextfield', - fieldLabel: gettext('IPv6 Prefix'), - labelWidth: 120, - name: 'ip6_prefix', - disabled: me.disableIpPrefixEdit, - allowBlank: true, - vtype: 'IP6CIDRAddress', - skipEmptyText: true, - deleteEmpty: !me.isCreate, - validator: function (value) { - let ipPrefix = this.up('window').down('[name=ip_prefix]')?.getValue(); - if (value || ipPrefix) { - return true; - } - return gettext('Either IPv4 Prefix or IPv6 Prefix is required'); - }, - listeners: { - change: function (textbox, value) { - let win = textbox.up('window'); - let vm = win.getViewModel(); - vm.set('showIpv6ForwardingHint', !!value); - win.down('[name=ip_prefix]')?.validate(); - }, + listeners: { + change: function (textbox) { + textbox.up('window').down('[name=ip_prefix]')?.validate(); }, }, - ); + }); } if (me.additionalTabs.length > 0) { -- 2.47.3