[PATCH-SERIES qemu 0/2] fix #7722: restore PNG support and drop libsdl dependency

[PATCH-SERIES qemu 0/2] fix #7722: restore PNG support and drop libsdl dependency

[Fiona Ebner]

See the individual patches for more information.

pve-qemu:

Fiona Ebner (2):
  fix #7722: d/{control,rules}: restore PNG support
  d/{control,rules}: drop libsdl dependency

 debian/control | 8 +++++++-
 debian/rules   | 4 ++++
 2 files changed, 11 insertions(+), 1 deletion(-)


Summary over all repositories:
  2 files changed, 11 insertions(+), 1 deletions(-)

-- 
Generated by git-murpp 0.5.0

[PATCH qemu 1/2] fix #7722: d/{control,rules}: restore PNG support

[Fiona Ebner]

PNG support is required for screendump and is advertised by VNC when
available. In Proxmox VE 8, the libpng-dev build dependency was pulled
in implicitly via
> i   sbuild-build-depends-main-dummy Depends libsdl1.2-dev
> i A libsdl1.2-dev                   Depends libcaca-dev
> i A libcaca-dev                     Depends libslang2-dev
> i A libslang2-dev                   Depends libpng-dev
and then CONFIG_PNG would be auto-enabled during build. Add back the
missing build dependency to fix the regression and be explicit
about enabling PNG support.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control | 1 +
 debian/rules   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/debian/control b/debian/control
index e3fc9a7847..4c4b8fa4a1 100644
--- a/debian/control
+++ b/debian/control
@@ -20,6 +20,7 @@ Build-Depends: debhelper-compat (= 13),
                libnuma-dev,
                libpci-dev,
                libpixman-1-dev,
+               libpng-dev,
                libproxmox-backup-qemu0-dev (>= 1.3.0),
                librbd-dev (>= 0.48),
                libsdl1.2-dev,
diff --git a/debian/rules b/debian/rules
index c20752735d..76f3c9b661 100755
--- a/debian/rules
+++ b/debian/rules
@@ -72,6 +72,7 @@ endif
 	    --enable-linux-io-uring \
 	    --enable-numa \
 	    --enable-opengl \
+	    --enable-png \
 	    --enable-rbd \
 	    --enable-seccomp \
 	    --enable-slirp \
-- 
2.47.3

[PATCH qemu 2/2] d/{control,rules}: drop libsdl dependency

[Fiona Ebner]

The --disable-sdl flag is used during build, but the libsdl1.2-dev
build dependency was still present in d/control. That dependency
implicitly pulled in others. Drop the libsdl build dependency and be
explicit about the dependencies that were previously pulled in and the
features they auto-enabled, namely:
* libasound2-dev for CONFIG_AUDIO_ALSA
* libdrm-dev for HAVE_DRM_H (this is only used for linux-user, so could
  be dropped with a major release if desired)
* libglib2.0-dev (glib is widely used in the QEMU source code)
* libpulse-dev for CONFIG_AUDIO_PA
* libsndio-dev for CONFIG_AUDIO_SNDIO
* libxkbcommon-dev for qemu-keymap

The non-alsa audio libraries could be dropped with a major release if
desired. It seems that enabling support might have been done
unintentionally, because in debian/rules, --audio-drv-list="alsa" is
used. However, the backends are still auto-enabled when the libraries
are found, this list seems to be only used for the priorities for the
default audio backend.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control | 7 ++++++-
 debian/rules   | 3 +++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 4c4b8fa4a1..ea9871d363 100644
--- a/debian/control
+++ b/debian/control
@@ -6,13 +6,16 @@ Build-Depends: debhelper-compat (= 13),
                check,
                libacl1-dev,
                libaio-dev,
+               libasound2-dev,
                libattr1-dev,
                libcap-ng-dev,
                libcurl4-gnutls-dev,
+               libdrm-dev,
                libepoxy-dev,
                libfdt-dev,
                libfuse3-dev,
                libgbm-dev,
+               libglib2.0-dev,
                libgnutls28-dev,
                libiscsi-dev (>= 1.12.0),
                libjpeg-dev,
@@ -22,10 +25,11 @@ Build-Depends: debhelper-compat (= 13),
                libpixman-1-dev,
                libpng-dev,
                libproxmox-backup-qemu0-dev (>= 1.3.0),
+               libpulse-dev,
                librbd-dev (>= 0.48),
-               libsdl1.2-dev,
                libseccomp-dev,
                libslirp-dev,
+               libsndio-dev,
                libspice-protocol-dev (>= 0.12.14~),
                libspice-server-dev (>= 0.14.0~),
                libsystemd-dev,
@@ -33,6 +37,7 @@ Build-Depends: debhelper-compat (= 13),
                libusb-1.0-0-dev (>= 1.0.17),
                libusbredirparser-dev (>= 0.6-2),
                libvirglrenderer-dev,
+               libxkbcommon-dev,
                libzstd-dev,
                meson,
                python3-minimal,
diff --git a/debian/rules b/debian/rules
index 76f3c9b661..a6b8745794 100755
--- a/debian/rules
+++ b/debian/rules
@@ -72,14 +72,17 @@ endif
 	    --enable-linux-io-uring \
 	    --enable-numa \
 	    --enable-opengl \
+	    --enable-pa \
 	    --enable-png \
 	    --enable-rbd \
 	    --enable-seccomp \
 	    --enable-slirp \
+	    --enable-sndio \
 	    --enable-spice \
 	    --enable-usb-redir \
 	    --enable-virglrenderer \
 	    --enable-virtfs \
+	    --enable-xkbcommon \
 	    --enable-zstd
 
 build: build-arch build-indep
-- 
2.47.3

Re: [PATCH-SERIES qemu 0/2] fix #7722: restore PNG support and drop libsdl dependency

[Samuel Rufinatscha]

Hi,

Thanks for the patches.

The packages built successfully.

Also, running

pvesh create /nodes/$(hostname)/qemu/<VMID>/monitor --command 
"screendump /tmp/test.png -f png"

produces the expected .PNG for the given VM. Therefore, consider it:

Tested-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>

Kind regards,
Samuel

On 6/23/26 5:30 PM, Fiona Ebner wrote:
> See the individual patches for more information.
> 
> pve-qemu:
> 
> Fiona Ebner (2):
>    fix #7722: d/{control,rules}: restore PNG support
>    d/{control,rules}: drop libsdl dependency
> 
>   debian/control | 8 +++++++-
>   debian/rules   | 4 ++++
>   2 files changed, 11 insertions(+), 1 deletion(-)
> 
> 
> Summary over all repositories:
>    2 files changed, 11 insertions(+), 1 deletions(-)
>