* [PATCH pve-guest-common] tunnel: websocket: prepend api token name when missing
@ 2026-06-18 11:04 Erik Fastermann
0 siblings, 0 replies; only message in thread
From: Erik Fastermann @ 2026-06-18 11:04 UTC (permalink / raw)
To: pve-devel; +Cc: Erik Fastermann
Ensure that the API token used in `fork_websocket_tunnel` is properly
prefixed with 'PVEAPIToken=' if it isn't already.
Previously, if a token was supplied without this explicit prefix,
initial API checks would pass successfully, but QEMU and LXC
migrations would abruptly fail midway with the error "server didn't
upgrade: 401 Unauthorized" when attempting to establish the websocket
tunnel. This inconsistency created a confusing user experience, as the
migration appeared to work fine initially.
The early API checks succeeded because `PVE::APIClient::LWP` already
automatically handles the missing prefix. This change brings the
websocket tunnel setup in line with that behavior, preventing mid-
migration failures when the prefix is omitted.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
src/PVE/Tunnel.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/Tunnel.pm b/src/PVE/Tunnel.pm
index 791b465..10f2bd6 100644
--- a/src/PVE/Tunnel.pm
+++ b/src/PVE/Tunnel.pm
@@ -234,6 +234,9 @@ sub fork_websocket_tunnel {
my ($conn, $url, $req_params, $tunnel_params, $log) = @_;
if (my $apitoken = $conn->{apitoken}) {
+ if ($apitoken !~ /^\w+(?:=| )/) {
+ $apitoken = "PVEAPIToken=${apitoken}";
+ }
$tunnel_params->{headers} = [["Authorization", "$apitoken"]];
} else {
die "can't connect to remote host without credentials\n";
--
2.47.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-18 11:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18 11:04 [PATCH pve-guest-common] tunnel: websocket: prepend api token name when missing Erik Fastermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.