[PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM

[PATCH datacenter-manager/yew-comp 0/3] Allow Editing of Default Realms in PDM

[Shannon Sterz]

the goal of this series is to allow editing of the two default realms (pam &
pdm) in PDM. currently users can neither change the comment nor set these
realms as the default login realm. this series fixes that and also cleans up
some comments for proxmox-yew-comp.


datacenter-manager:

Shannon Sterz (1):
  server: api: access: add endpoints for configuring pdm and pam realms

 lib/pdm-api-types/src/lib.rs                  |  96 ++++++++++++++
 lib/pdm-config/src/domains.rs                 |  37 +++++-
 server/src/api/access/domains.rs              |  16 +--
 server/src/api/config/access/mod.rs           |   4 +
 server/src/api/config/access/pam.rs           | 119 ++++++++++++++++++
 server/src/api/config/access/pdm.rs           | 119 ++++++++++++++++++
 .../bin/proxmox-datacenter-privileged-api.rs  |   1 +
 7 files changed, 375 insertions(+), 17 deletions(-)
 create mode 100644 server/src/api/config/access/pam.rs
 create mode 100644 server/src/api/config/access/pdm.rs


yew-comp:

Shannon Sterz (2):
  auth_view: enable editing of default realms
  auth_view: clarify the documentation of pre-existing properties

 src/auth_view.rs | 61 ++++++++++++++++++++++++++++++++++++++++++------
 src/utils/mod.rs |  4 ++--
 2 files changed, 56 insertions(+), 9 deletions(-)


Summary over all repositories:
  9 files changed, 431 insertions(+), 26 deletions(-)

-- 
Generated by murpp 0.12.0

[PATCH datacenter-manager 1/3] server: api: access: add endpoints for configuring pdm and pam realms

[Shannon Sterz]

this allows users to set those realms as default realms and also
allows editing their comments.

also makes sure that the pam and pdm realms exist in the domains.cfg

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 lib/pdm-api-types/src/lib.rs                  |  96 ++++++++++++++
 lib/pdm-config/src/domains.rs                 |  37 +++++-
 server/src/api/access/domains.rs              |  16 +--
 server/src/api/config/access/mod.rs           |   4 +
 server/src/api/config/access/pam.rs           | 119 ++++++++++++++++++
 server/src/api/config/access/pdm.rs           | 119 ++++++++++++++++++
 .../bin/proxmox-datacenter-privileged-api.rs  |   1 +
 7 files changed, 375 insertions(+), 17 deletions(-)
 create mode 100644 server/src/api/config/access/pam.rs
 create mode 100644 server/src/api/config/access/pdm.rs

diff --git a/lib/pdm-api-types/src/lib.rs b/lib/pdm-api-types/src/lib.rs
index b9cc3234..89d1b4ad 100644
--- a/lib/pdm-api-types/src/lib.rs
+++ b/lib/pdm-api-types/src/lib.rs
@@ -391,6 +391,102 @@ pub struct BasicRealmInfo {
     pub comment: Option<String>,
 }
 
+#[api(
+    properties: {
+        realm: {
+            schema: REALM_ID_SCHEMA,
+        },
+        "type": {
+            type: RealmType,
+        },
+        comment: {
+            optional: true,
+            schema: SINGLE_LINE_COMMENT_SCHEMA,
+        },
+        "default": {
+            optional: true,
+            default: false,
+        },
+    }
+)]
+#[derive(Serialize, Deserialize, Updater, Clone)]
+#[serde(rename_all = "kebab-case")]
+/// Built-in PAM realm configuration properties.
+pub struct PamRealmConfig {
+    /// Realm name. Always "pam".
+    #[updater(skip)]
+    pub realm: String,
+    /// Realm type. Always [`RealmType::Pam`].
+    #[updater(skip)]
+    #[serde(rename = "type")]
+    pub ty: RealmType,
+    /// Comment for this realm
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub comment: Option<String>,
+    /// True if you want this to be the default realm selected on login.
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub default: Option<bool>,
+}
+
+impl Default for PamRealmConfig {
+    fn default() -> Self {
+        Self {
+            realm: "pam".to_owned(),
+            ty: RealmType::Pam,
+            comment: Some("Linux PAM standard authentication".to_owned()),
+            default: None,
+        }
+    }
+}
+
+#[api(
+    properties: {
+        realm: {
+            schema: REALM_ID_SCHEMA,
+        },
+        "type": {
+            type: RealmType,
+        },
+        comment: {
+            optional: true,
+            schema: SINGLE_LINE_COMMENT_SCHEMA,
+        },
+        "default": {
+            optional: true,
+            default: false,
+        },
+    }
+)]
+#[derive(Serialize, Deserialize, Updater, Clone)]
+#[serde(rename_all = "kebab-case")]
+/// Built-in Proxmox Datacenter Manager realm configuration properties.
+pub struct PdmRealmConfig {
+    /// Realm name. Always "pdm".
+    #[updater(skip)]
+    pub realm: String,
+    /// Realm type. Always [`RealmType::Pdm`].
+    #[updater(skip)]
+    #[serde(rename = "type")]
+    pub ty: RealmType,
+    /// Comment for this realm
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub comment: Option<String>,
+    /// True if you want this to be the default realm selected on login.
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub default: Option<bool>,
+}
+
+impl Default for PdmRealmConfig {
+    fn default() -> Self {
+        Self {
+            realm: "pdm".to_owned(),
+            ty: RealmType::Pdm,
+            comment: Some("Proxmox Datacenter Manager authentication server".to_owned()),
+            default: None,
+        }
+    }
+}
+
 #[api]
 /// Guest configuration access.
 #[derive(Clone, Copy, Debug, Default, Deserialize, Serialize, Updater)]
diff --git a/lib/pdm-config/src/domains.rs b/lib/pdm-config/src/domains.rs
index fa9c6e72..7b4b75e5 100644
--- a/lib/pdm-config/src/domains.rs
+++ b/lib/pdm-config/src/domains.rs
@@ -7,7 +7,9 @@ use proxmox_ldap::types::{AdRealmConfig, LdapRealmConfig};
 use proxmox_schema::{ApiType, Schema};
 use proxmox_section_config::{SectionConfig, SectionConfigData, SectionConfigPlugin};
 
-use pdm_api_types::{ConfigDigest, OpenIdRealmConfig, REALM_ID_SCHEMA};
+use pdm_api_types::{
+    ConfigDigest, OpenIdRealmConfig, PamRealmConfig, PdmRealmConfig, REALM_ID_SCHEMA,
+};
 use proxmox_product_config::{ApiLockGuard, open_api_lockfile, replace_privileged_config};
 
 use pdm_buildcfg::configdir;
@@ -15,6 +17,22 @@ use pdm_buildcfg::configdir;
 pub static CONFIG: LazyLock<SectionConfig> = LazyLock::new(init);
 
 fn init() -> SectionConfig {
+    let mut config = SectionConfig::new(&REALM_ID_SCHEMA);
+
+    let plugin = SectionConfigPlugin::new(
+        "pam".to_owned(),
+        Some("realm".to_owned()),
+        PamRealmConfig::API_SCHEMA.unwrap_object_schema(),
+    );
+    config.register_plugin(plugin);
+
+    let plugin = SectionConfigPlugin::new(
+        "pdm".to_owned(),
+        Some("realm".to_owned()),
+        PdmRealmConfig::API_SCHEMA.unwrap_object_schema(),
+    );
+    config.register_plugin(plugin);
+
     let obj_schema = match OpenIdRealmConfig::API_SCHEMA {
         Schema::Object(ref obj_schema) => obj_schema,
         _ => unreachable!(),
@@ -25,7 +43,6 @@ fn init() -> SectionConfig {
         Some(String::from("realm")),
         obj_schema,
     );
-    let mut config = SectionConfig::new(&REALM_ID_SCHEMA);
     config.register_plugin(plugin);
 
     let ldap_plugin = SectionConfigPlugin::new(
@@ -110,3 +127,19 @@ pub fn unset_default_realm(config: &mut SectionConfigData) -> Result<(), Error>
 pub fn exists(domains: &SectionConfigData, realm: &str) -> bool {
     domains.sections.contains_key(realm)
 }
+
+/// Add the pam and pdm realms to the config if they don't exist. These should always be added.
+pub fn add_default_realms() -> Result<(), Error> {
+    let _lock = lock_config()?;
+    let (mut domains, _) = config()?;
+
+    if !exists(&domains, "pam") {
+        domains.set_data("pam", "pam", PamRealmConfig::default())?;
+    }
+
+    if !exists(&domains, "pdm") {
+        domains.set_data("pdm", "pdm", PdmRealmConfig::default())?;
+    }
+
+    save_config(&domains)
+}
diff --git a/server/src/api/access/domains.rs b/server/src/api/access/domains.rs
index 06abfb92..18adaa4e 100644
--- a/server/src/api/access/domains.rs
+++ b/server/src/api/access/domains.rs
@@ -27,21 +27,7 @@ use pdm_api_types::{Authid, BasicRealmInfo, RealmRef, RealmType, UPID_SCHEMA};
 )]
 /// Authentication domain/realm index.
 fn list_domains(rpcenv: &mut dyn RpcEnvironment) -> Result<Vec<BasicRealmInfo>, Error> {
-    let mut list = vec![
-        BasicRealmInfo {
-            realm: "pam".to_string(),
-            ty: RealmType::Pam,
-            default: None,
-            comment: Some("Linux PAM standard authentication".to_string()),
-        },
-        BasicRealmInfo {
-            realm: "pdm".to_string(),
-            ty: RealmType::Pdm,
-            default: None,
-            comment: Some("Proxmox Datacenter Manager authentication".to_string()),
-        },
-    ];
-
+    let mut list = Vec::new();
     let (config, digest) = pdm_config::domains::config()?;
 
     for (_, (section_type, v)) in config.sections.iter() {
diff --git a/server/src/api/config/access/mod.rs b/server/src/api/config/access/mod.rs
index 57761522..ba6d5e32 100644
--- a/server/src/api/config/access/mod.rs
+++ b/server/src/api/config/access/mod.rs
@@ -5,6 +5,8 @@ use proxmox_sortable_macro::sortable;
 mod ad;
 mod ldap;
 mod openid;
+mod pam;
+mod pdm;
 pub mod tfa;
 
 #[sortable]
@@ -13,6 +15,8 @@ const SUBDIRS: SubdirMap = &sorted!([
     ("ldap", &ldap::ROUTER),
     ("openid", &openid::ROUTER),
     ("ad", &ad::ROUTER),
+    ("pam", &pam::ROUTER),
+    ("pdm", &pdm::ROUTER),
 ]);
 
 pub const ROUTER: Router = Router::new()
diff --git a/server/src/api/config/access/pam.rs b/server/src/api/config/access/pam.rs
new file mode 100644
index 00000000..93ab1910
--- /dev/null
+++ b/server/src/api/config/access/pam.rs
@@ -0,0 +1,119 @@
+use anyhow::Error;
+use serde::{Deserialize, Serialize};
+
+use proxmox_config_digest::ConfigDigest;
+use proxmox_router::{Permission, Router, RpcEnvironment};
+use proxmox_schema::api;
+
+use pdm_api_types::{PRIV_REALM_ALLOCATE, PRIV_SYS_AUDIT, PamRealmConfig, PamRealmConfigUpdater};
+use pdm_config::domains;
+
+#[api(
+    returns: {
+        type: PamRealmConfig,
+    },
+    access: {
+        permission: &Permission::Privilege(&["access", "domains"], PRIV_SYS_AUDIT, false),
+    },
+)]
+/// Read the PAM realm configuration
+pub fn read_pam_realm(rpcenv: &mut dyn RpcEnvironment) -> Result<PamRealmConfig, Error> {
+    let (domains, digest) = domains::config()?;
+
+    let config = domains.lookup("pam", "pam")?;
+
+    rpcenv["digest"] = digest.to_hex().into();
+
+    Ok(config)
+}
+
+#[api]
+#[derive(Serialize, Deserialize)]
+#[serde(rename_all = "kebab-case")]
+/// Deletable property name
+pub enum DeletableProperty {
+    /// Delete the comment property.
+    Comment,
+    /// Delete the default property.
+    Default,
+}
+
+#[api(
+    protected: true,
+    input: {
+        properties: {
+            update: {
+                type: PamRealmConfigUpdater,
+                flatten: true,
+            },
+            delete: {
+                description: "List of properties to delete.",
+                type: Array,
+                optional: true,
+                items: {
+                    type: DeletableProperty,
+                }
+            },
+            digest: {
+                optional: true,
+                type: ConfigDigest,
+            },
+        },
+    },
+    returns: {
+        type: PamRealmConfig,
+    },
+    access: {
+        permission: &Permission::Privilege(&["access", "domains"], PRIV_REALM_ALLOCATE, false),
+    },
+)]
+/// Update the PAM realm configuration
+pub fn update_pam_realm(
+    update: PamRealmConfigUpdater,
+    delete: Option<Vec<DeletableProperty>>,
+    digest: Option<ConfigDigest>,
+    _rpcenv: &mut dyn RpcEnvironment,
+) -> Result<(), Error> {
+    let _lock = domains::lock_config()?;
+
+    let (mut domains, expected_digest) = domains::config()?;
+
+    expected_digest.detect_modification(digest.as_ref())?;
+
+    let mut config: PamRealmConfig = domains.lookup("pam", "pam")?;
+
+    if let Some(delete) = delete {
+        for delete_prop in delete {
+            match delete_prop {
+                DeletableProperty::Comment => config.comment = None,
+                DeletableProperty::Default => config.default = None,
+            }
+        }
+    }
+
+    if let Some(comment) = update.comment {
+        let comment = comment.trim().to_string();
+        if comment.is_empty() {
+            config.comment = None;
+        } else {
+            config.comment = Some(comment);
+        }
+    }
+
+    if let Some(true) = update.default {
+        pdm_config::domains::unset_default_realm(&mut domains)?;
+        config.default = Some(true);
+    } else {
+        config.default = None;
+    }
+
+    domains.set_data("pam", "pam", &config)?;
+
+    domains::save_config(&domains)?;
+
+    Ok(())
+}
+
+pub const ROUTER: Router = Router::new()
+    .get(&API_METHOD_READ_PAM_REALM)
+    .put(&API_METHOD_UPDATE_PAM_REALM);
diff --git a/server/src/api/config/access/pdm.rs b/server/src/api/config/access/pdm.rs
new file mode 100644
index 00000000..e35cba0c
--- /dev/null
+++ b/server/src/api/config/access/pdm.rs
@@ -0,0 +1,119 @@
+use ::serde::{Deserialize, Serialize};
+use anyhow::Error;
+
+use proxmox_config_digest::ConfigDigest;
+use proxmox_router::{Permission, Router, RpcEnvironment};
+use proxmox_schema::api;
+
+use pdm_api_types::{PRIV_REALM_ALLOCATE, PRIV_SYS_AUDIT, PdmRealmConfig, PdmRealmConfigUpdater};
+use pdm_config::domains;
+
+#[api(
+    returns: {
+        type: PdmRealmConfig,
+    },
+    access: {
+        permission: &Permission::Privilege(&["access", "domains"], PRIV_SYS_AUDIT, false),
+    },
+)]
+/// Read the Proxmox Datacenter Manager authentication server realm configuration
+pub fn read_pdm_realm(rpcenv: &mut dyn RpcEnvironment) -> Result<PdmRealmConfig, Error> {
+    let (domains, digest) = domains::config()?;
+
+    let config = domains.lookup("pdm", "pdm")?;
+
+    rpcenv["digest"] = digest.to_hex().into();
+
+    Ok(config)
+}
+
+#[api]
+#[derive(Serialize, Deserialize)]
+#[serde(rename_all = "kebab-case")]
+/// Deletable property name
+pub enum DeletableProperty {
+    /// Delete the comment property.
+    Comment,
+    /// Delete the default property.
+    Default,
+}
+
+#[api(
+    protected: true,
+    input: {
+        properties: {
+            update: {
+                type: PdmRealmConfigUpdater,
+                flatten: true,
+            },
+            delete: {
+                description: "List of properties to delete.",
+                type: Array,
+                optional: true,
+                items: {
+                    type: DeletableProperty,
+                }
+            },
+            digest: {
+                optional: true,
+                type: ConfigDigest,
+            },
+        },
+    },
+    returns: {
+        type: PdmRealmConfig,
+    },
+    access: {
+        permission: &Permission::Privilege(&["access", "domains"], PRIV_REALM_ALLOCATE, false),
+    },
+)]
+/// Update the Proxmox Datacenter Manager authentication server realm configuration
+pub fn update_pdm_realm(
+    update: PdmRealmConfigUpdater,
+    delete: Option<Vec<DeletableProperty>>,
+    digest: Option<ConfigDigest>,
+    _rpcenv: &mut dyn RpcEnvironment,
+) -> Result<(), Error> {
+    let _lock = domains::lock_config()?;
+
+    let (mut domains, expected_digest) = domains::config()?;
+
+    expected_digest.detect_modification(digest.as_ref())?;
+
+    let mut config: PdmRealmConfig = domains.lookup("pdm", "pdm")?;
+
+    if let Some(delete) = delete {
+        for delete_prop in delete {
+            match delete_prop {
+                DeletableProperty::Comment => config.comment = None,
+                DeletableProperty::Default => config.default = None,
+            }
+        }
+    }
+
+    if let Some(comment) = update.comment {
+        let comment = comment.trim().to_string();
+        if comment.is_empty() {
+            config.comment = None;
+        } else {
+            config.comment = Some(comment);
+        }
+    }
+
+    if let Some(true) = update.default {
+        pdm_config::domains::unset_default_realm(&mut domains)?;
+        config.default = Some(true);
+    } else {
+        config.default = None;
+    }
+
+    domains.set_data("pdm", "pdm", &config)?;
+
+    domains::save_config(&domains)?;
+
+    Ok(())
+}
+
+pub const ROUTER: Router = Router::new()
+    .get(&API_METHOD_READ_PDM_REALM)
+    .put(&API_METHOD_UPDATE_PDM_REALM);
diff --git a/server/src/bin/proxmox-datacenter-privileged-api.rs b/server/src/bin/proxmox-datacenter-privileged-api.rs
index fdc4e8a9..59d30513 100644
--- a/server/src/bin/proxmox-datacenter-privileged-api.rs
+++ b/server/src/bin/proxmox-datacenter-privileged-api.rs
@@ -118,6 +118,7 @@ async fn run() -> Result<(), Error> {
     auth::init(true);
 
     proxmox_acme_api::init(configdir!("/acme"), true)?;
+    pdm_config::domains::add_default_realms()?;
 
     let api_user = pdm_config::api_user()?;
     let mut command_sock = proxmox_daemon::command_socket::CommandSocket::new(api_user.gid);
-- 
2.47.3

[PATCH yew-comp 2/3] auth_view: enable editing of default realms

[Shannon Sterz]

so users can set custom comments and mark them as default realm if
required.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/auth_view.rs | 52 ++++++++++++++++++++++++++++++++++++++++++++++--
 src/utils/mod.rs |  4 ++--
 2 files changed, 52 insertions(+), 4 deletions(-)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 9a06979..8be682a 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -5,7 +5,7 @@ use std::rc::Rc;
 use anyhow::Error;
 
 use proxmox_client::ApiResponseData;
-use pwt::widget::form::{Checkbox, FormContext, TristateBoolean};
+use pwt::widget::form::{Checkbox, DisplayField, Field, FormContext, TristateBoolean};
 use serde_json::Value;
 use yew::html::IntoPropValue;
 use yew::virtual_dom::{VComp, VNode};
@@ -19,6 +19,7 @@ use pwt::widget::{Button, Container, Fa, InputPanel, Toolbar};
 
 use pwt_macros::builder;
 
+use crate::form::delete_empty_values;
 use crate::{
     AuthEditLDAP, AuthEditOpenID, EditWindow, LoadableComponent, LoadableComponentContext,
     LoadableComponentMaster, LoadableComponentScope, LoadableComponentScopeExt,
@@ -37,6 +38,12 @@ pub struct AuthView {
     /// The base url for
     pub base_url: AttrValue,
 
+    /// The base URL to edit the default realms (pam, pve, pdm, pbs etc.). Specify `None` if
+    /// editing the default realms is not supported.
+    #[prop_or(Some("/config/access/".into()))]
+    #[builder(IntoPropValue, into_prop_value)]
+    pub edit_default_realms_base_url: Option<AttrValue>,
+
     /// Allow to add/edit OpenID entries
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
@@ -73,6 +80,7 @@ pub enum ViewState {
     EditOpenID(AttrValue),
     EditLDAP(AttrValue),
     EditAd(AttrValue),
+    EditDefaultRealm(AttrValue),
     Sync(BasicRealmInfo),
 }
 
@@ -164,6 +172,33 @@ async fn load_realm(url: impl Into<String>) -> Result<ApiResponseData<Value>, Er
     Ok(response)
 }
 
+fn edit_default_realm(realm: AttrValue, url: AttrValue) -> EditWindow {
+    let url = format!("{url}/{realm}");
+    EditWindow::new(tr!("Edit: {realm}", realm))
+        .loader(url.clone())
+        .renderer({
+            move |_form_ctx: &FormContext| {
+                InputPanel::new()
+                    .padding(4)
+                    .with_field(
+                        tr!("Realm"),
+                        DisplayField::new().name("realm").submit(false),
+                    )
+                    .with_right_field(tr!("Default Realm"), Checkbox::new().name("default"))
+                    .with_large_field(tr!("Comment"), Field::new().name("comment"))
+                    .into()
+            }
+        })
+        .on_submit(move |form_ctx: FormContext| {
+            let url = url.clone();
+            async move {
+                let data = form_ctx.get_submit_data();
+                let data = delete_empty_values(&data, &["comment"], true);
+                crate::http_put(&url, Some(data)).await
+            }
+        })
+}
+
 impl ProxmoxAuthView {
     fn get_selected_record(&self) -> Option<BasicRealmInfo> {
         let selected_key = self.selection.selected_key();
@@ -254,6 +289,11 @@ impl LoadableComponent for ProxmoxAuthView {
                     "ad" if props.ad_base_url.is_some() => {
                         Some(ViewState::EditAd(info.realm.into()))
                     }
+                    "pam" | "pbs" | "pdm" | "pve"
+                        if props.edit_default_realms_base_url.is_some() =>
+                    {
+                        Some(ViewState::EditDefaultRealm(info.realm.into()))
+                    }
                     _ => return true,
                 };
 
@@ -285,7 +325,7 @@ impl LoadableComponent for ProxmoxAuthView {
             if let Some(auth_info) = crate::utils::get_auth_domain_info(&realm_info.ty) {
                 sync_disabled = !auth_info.sync;
                 remove_disabled = !auth_info.add;
-                edit_disabled = !auth_info.add;
+                edit_disabled = !auth_info.edit;
             }
         }
 
@@ -408,6 +448,14 @@ impl LoadableComponent for ProxmoxAuthView {
                     .on_close(ctx.link().change_view_callback(|_| None))
                     .into(),
             ),
+            ViewState::EditDefaultRealm(realm) => Some(
+                edit_default_realm(
+                    realm.clone(),
+                    props.edit_default_realms_base_url.clone().unwrap(),
+                )
+                .on_done(ctx.link().change_view_callback(|_| None))
+                .into(),
+            ),
             ViewState::Sync(realm) => {
                 let link = ctx.link().clone();
                 let url = format!(
diff --git a/src/utils/mod.rs b/src/utils/mod.rs
index c007286..25fd414 100644
--- a/src/utils/mod.rs
+++ b/src/utils/mod.rs
@@ -172,7 +172,7 @@ pub fn get_auth_domain_info(ty: &str) -> Option<AuthDomainInfo> {
             ty: ty.to_string(),
             //description: tr!("Linux PAM"),
             add: false,
-            edit: false,
+            edit: true,
             tfa: true,
             pwchange: false,
             sync: false,
@@ -184,7 +184,7 @@ pub fn get_auth_domain_info(ty: &str) -> Option<AuthDomainInfo> {
             ty: ty.to_string(),
             //description: tr!("Proxmox VE authentication server"),
             add: false,
-            edit: false,
+            edit: true,
             tfa: true,
             pwchange: true,
             sync: false,
-- 
2.47.3

[PATCH yew-comp 3/3] auth_view: clarify the documentation of pre-existing properties

[Shannon Sterz]

so it's a bit clearer what effect these properties have.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/auth_view.rs | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/auth_view.rs b/src/auth_view.rs
index 8be682a..e46c849 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -32,10 +32,9 @@ use crate::percent_encoding::percent_encode_component;
 #[derive(PartialEq, Properties)]
 #[builder]
 pub struct AuthView {
-    /// Base API path.
+    /// Base API path to fetch configured realms.
     #[prop_or("/access/domains".into())]
     #[builder(IntoPropValue, into_prop_value)]
-    /// The base url for
     pub base_url: AttrValue,
 
     /// The base URL to edit the default realms (pam, pve, pdm, pbs etc.). Specify `None` if
@@ -44,17 +43,17 @@ pub struct AuthView {
     #[builder(IntoPropValue, into_prop_value)]
     pub edit_default_realms_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit OpenID entries
+    /// Base URL to allow adding and editing of OpenID realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     openid_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit LDAP entries
+    /// Base URL to allow adding and editing of LDAP realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     ldap_base_url: Option<AttrValue>,
 
-    /// Allow to add/edit LDAP entries
+    /// Base URL to allow adding and editing of Active Directory realms.
     #[builder(IntoPropValue, into_prop_value)]
     #[prop_or_default]
     ad_base_url: Option<AttrValue>,
-- 
2.47.3