all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests
@ 2026-05-06 23:00 Ilan Karasik
  2026-06-16 10:22 ` Fabian Grünbichler
  0 siblings, 1 reply; 3+ messages in thread
From: Ilan Karasik @ 2026-05-06 23:00 UTC (permalink / raw)
  To: pve-devel; +Cc: iamkarasik

From: iamkarasik <ilankarasik@gmail.com>

Signed-off-by: iamkarasik <ilankarasik@gmail.com>
---
 src/PVE/LXC/Setup/Debian.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/Setup/Debian.pm
index 837397b..bbf73d5 100644
--- a/src/PVE/LXC/Setup/Debian.pm
+++ b/src/PVE/LXC/Setup/Debian.pm
@@ -284,6 +284,7 @@ sub setup_network {
                     $net->{needsroute6} = 1;
                 }
             }
+            $net->{mtu} = $d->{mtu} if defined($d->{mtu});
             $networks->{ $d->{name} } = $net if keys %$net;
         }
     }
@@ -337,6 +338,7 @@ sub setup_network {
                         $interfaces .= "\tgateway $gw\n";
                     }
                 }
+                $interfaces .= "\tmtu $net->{mtu}\n" if defined($net->{mtu});
                 foreach my $attr (@{ $section->{attr} }) {
                     $interfaces .= "\t$attr\n";
                 }
@@ -450,6 +452,7 @@ sub setup_network {
                     || $aname eq 'netmask'
                     || $aname eq 'gateway'
                     || $aname eq 'broadcast'
+                    || $aname eq 'mtu'
                 ) {
                     # skip
                 } else {
-- 
2.51.2




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests
  2026-05-06 23:00 [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests Ilan Karasik
@ 2026-06-16 10:22 ` Fabian Grünbichler
  2026-06-17 18:32   ` [PATCH v2] " Ilan Karasik
  0 siblings, 1 reply; 3+ messages in thread
From: Fabian Grünbichler @ 2026-06-16 10:22 UTC (permalink / raw)
  To: Ilan Karasik, pve-devel

Hi!

please see https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
for our CLA requirements, and send a signed copy as instructed there.

On May 7, 2026 1:00 am, Ilan Karasik wrote:
> From: iamkarasik <ilankarasik@gmail.com>

please add a short description of the commit/patch here, see our
developer documentation for details:

> Do not put in a literal description of the code diff, especially not
> for simpler changes. The commit message should not focus on the
> detailed what's done/changed but rather answer:
>
>    Why this was done otherwise previously (or why this was missing
>    until now).
>
>    Why the new approach is better or necessary (e.g., a
>    bug was found, requirements changed, a prerequisite was merged that
>    enables this).
>
>    What the resulting effect is for users or developers
>    (if not already obvious from the subject line). If there should be
>    no visible/semantic change then explicitly stating so can also be
>    good for non-trivial changes.

Thanks!

> 
> Signed-off-by: iamkarasik <ilankarasik@gmail.com>
> ---
>  src/PVE/LXC/Setup/Debian.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/Setup/Debian.pm
> index 837397b..bbf73d5 100644
> --- a/src/PVE/LXC/Setup/Debian.pm
> +++ b/src/PVE/LXC/Setup/Debian.pm
> @@ -284,6 +284,7 @@ sub setup_network {
>                      $net->{needsroute6} = 1;
>                  }
>              }
> +            $net->{mtu} = $d->{mtu} if defined($d->{mtu});
>              $networks->{ $d->{name} } = $net if keys %$net;
>          }
>      }
> @@ -337,6 +338,7 @@ sub setup_network {
>                          $interfaces .= "\tgateway $gw\n";
>                      }
>                  }
> +                $interfaces .= "\tmtu $net->{mtu}\n" if defined($net->{mtu});
>                  foreach my $attr (@{ $section->{attr} }) {
>                      $interfaces .= "\t$attr\n";
>                  }
> @@ -450,6 +452,7 @@ sub setup_network {
>                      || $aname eq 'netmask'
>                      || $aname eq 'gateway'
>                      || $aname eq 'broadcast'
> +                    || $aname eq 'mtu'
>                  ) {
>                      # skip
>                  } else {
> -- 
> 2.51.2
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] fix #7571: emit mtu in ifupdown-based LXC guests
  2026-06-16 10:22 ` Fabian Grünbichler
@ 2026-06-17 18:32   ` Ilan Karasik
  0 siblings, 0 replies; 3+ messages in thread
From: Ilan Karasik @ 2026-06-17 18:32 UTC (permalink / raw)
  To: pve-devel; +Cc: Ilan Karasik

This fixes a bug where custom mtu settings applied to an LXC container
are silently ignored during network setup for Debian-based guests
using ifupdown.

Because the Proxmox network setup was failing to write the mtu value
to the guest's `/etc/network/interfaces` file, the container would
always default to an mtu of 1500.

This patch resolves the issue by writing the `mtu <value>` directive into the
guest's network configuration file at /etc/network/interfaces.

Signed-off-by: Ilan Karasik <ilankarasik@gmail.com>
---
 src/PVE/LXC/Setup/Debian.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/Setup/Debian.pm
index 837397b..bbf73d5 100644
--- a/src/PVE/LXC/Setup/Debian.pm
+++ b/src/PVE/LXC/Setup/Debian.pm
@@ -284,6 +284,7 @@ sub setup_network {
                     $net->{needsroute6} = 1;
                 }
             }
+            $net->{mtu} = $d->{mtu} if defined($d->{mtu});
             $networks->{ $d->{name} } = $net if keys %$net;
         }
     }
@@ -337,6 +338,7 @@ sub setup_network {
                         $interfaces .= "\tgateway $gw\n";
                     }
                 }
+                $interfaces .= "\tmtu $net->{mtu}\n" if defined($net->{mtu});
                 foreach my $attr (@{ $section->{attr} }) {
                     $interfaces .= "\t$attr\n";
                 }
@@ -450,6 +452,7 @@ sub setup_network {
                     || $aname eq 'netmask'
                     || $aname eq 'gateway'
                     || $aname eq 'broadcast'
+                    || $aname eq 'mtu'
                 ) {
                     # skip
                 } else {
-- 
2.51.2




^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-18  6:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 23:00 [PATCH pve-container] fix #7571: emit mtu in ifupdown-based LXC guests Ilan Karasik
2026-06-16 10:22 ` Fabian Grünbichler
2026-06-17 18:32   ` [PATCH v2] " Ilan Karasik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal