all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH guest-common] storage tunnel: query disk import: adapt to current signature for file_size_info()
@ 2026-06-09 11:33 Fiona Ebner
  0 siblings, 0 replies; only message in thread
From: Fiona Ebner @ 2026-06-09 11:33 UTC (permalink / raw)
  To: pve-devel

In pve-storage commit 8364895 ("file size info: allow specifying file
format"), a new parameter for the format was added to the signature of
file_size_info() and while calls without a format parameter are
properly translated and still work (for now), they will trigger a
deprecation warning:

> file_size_info: detected call with legacy parameter order:
> $untrusted before $file_format

Adapt to the new signature to avoid this. The change landed in
libpve-storage-perl=8.2.10, and d/control already requires
libpve-storage-perl (>= 8.3.4).

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/StorageTunnel.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/StorageTunnel.pm b/src/PVE/StorageTunnel.pm
index 3a9c696..864aa0e 100644
--- a/src/PVE/StorageTunnel.pm
+++ b/src/PVE/StorageTunnel.pm
@@ -297,7 +297,8 @@ sub handle_query_disk_import {
         # check imported image for bad references
         if ($scfg->{path}) {
             my $path = PVE::Storage::path($cfg, $volid);
-            PVE::Storage::file_size_info($path, undef, 1);
+            my $format = (PVE::Storage::parse_volname($cfg, $volid))[6];
+            PVE::Storage::file_size_info($path, undef, $format, 1);
         }
 
         return {
-- 
2.47.3





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-06-09 11:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-09 11:33 [PATCH guest-common] storage tunnel: query disk import: adapt to current signature for file_size_info() Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal