all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field
@ 2026-05-28  9:27 Dominik Csapak
  2026-05-28  9:27 ` [PATCH datacenter-manager 2/2] ui: auto-installer: add missing keys for the input panels Dominik Csapak
  2026-05-28  9:39 ` applied: [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Lukas Wagner
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-05-28  9:27 UTC (permalink / raw)
  To: pdm-devel

there is no reason why this field should get a custom height, and on
chrome, this adds a vertical scrollbar to the field.

Simply remove it.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/remotes/auto_installer/prepared_answer_form.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index 4f7f4f3d..b209eb2c 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -1037,7 +1037,6 @@ pub fn render_show_secret_dialog(
                     Field::new()
                         .input_type(InputType::Password)
                         .class(FlexFit)
-                        .style("height", "2em")
                         .value(commandline.to_owned())
                         .read_only(true),
                 )
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH datacenter-manager 2/2] ui: auto-installer: add missing keys for the input panels
  2026-05-28  9:27 [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Dominik Csapak
@ 2026-05-28  9:27 ` Dominik Csapak
  2026-05-28  9:39 ` applied: [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Lukas Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-05-28  9:27 UTC (permalink / raw)
  To: pdm-devel

input panels need a key for each field/child. It tries to auto-generate
them, but this generates a warning in debug mode. So just add the
missing keys for the custom children.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index b209eb2c..560503a4 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -882,6 +882,7 @@ pub fn render_templating_form(config: &PreparedInstallationConfig) -> yew::Html
         )
         .with_large_custom_child(
             KeyValueList::new()
+                .key("current-value")
                 .value(
                     config
                         .template_counters
@@ -922,6 +923,7 @@ pub fn render_auth_form(
         )
         .with_large_custom_child(
             TokenSelector::new(tokens)
+                .key("authorized-tokens")
                 .selected_keys(config.authorized_tokens.clone())
                 .required(false)
                 .submit_empty(true)
@@ -983,6 +985,7 @@ pub fn render_show_secret_dialog(
     let token = format!("{}:{secret}", token.id);
 
     let copy_token_view = Container::new()
+        .key("copy-token-view")
         .class("pwt-form-grid-col4")
         .with_child(FieldLabel::new(tr!("Token")))
         .with_child(
@@ -1027,6 +1030,7 @@ pub fn render_show_secret_dialog(
     commandline = format!("{commandline} INPUT.iso");
 
     let copy_commandline_view = Container::new()
+        .key("copy-commandline-view")
         .class("pwt-form-grid-col4")
         .with_child(FieldLabel::new(tr!("Command Line")))
         .with_child(
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* applied: [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field
  2026-05-28  9:27 [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Dominik Csapak
  2026-05-28  9:27 ` [PATCH datacenter-manager 2/2] ui: auto-installer: add missing keys for the input panels Dominik Csapak
@ 2026-05-28  9:39 ` Lukas Wagner
  1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2026-05-28  9:39 UTC (permalink / raw)
  To: pdm-devel, Dominik Csapak


On Thu, 28 May 2026 11:27:13 +0200, Dominik Csapak wrote:
> there is no reason why this field should get a custom height, and on
> chrome, this adds a vertical scrollbar to the field.
> 
> Simply remove it.
> 
> 

Applied, thanks!

[1/2] ui: auto-installer: remove stray 'height' property for the command field
      commit: ffac346e1eac5d650f7a94f4bcfd77f5203f0794
[2/2] ui: auto-installer: add missing keys for the input panels
      commit: 9acbe7df85de7efaee30891fe9d363293551ca2a

Best regards,
-- 
Lukas Wagner <l.wagner@proxmox.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-28  9:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28  9:27 [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Dominik Csapak
2026-05-28  9:27 ` [PATCH datacenter-manager 2/2] ui: auto-installer: add missing keys for the input panels Dominik Csapak
2026-05-28  9:39 ` applied: [PATCH datacenter-manager 1/2] ui: auto-installer: remove stray 'height' property for the command field Lukas Wagner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal