* [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab
@ 2026-05-27 7:56 Hannes Laimer
2026-05-27 8:02 ` applied: " Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-05-27 7:56 UTC (permalink / raw)
To: pdm-devel
We don't show the advanced checkbox, so having the filter in the
advanced section will always have it hidden. This prevents submitting
cause the filter is required for static ip configurations. The disks
form has the same scenario, "advanced filtering" required based on form
input.
Not having it in advanced also makes sense cause advanced usually
implies optionality, which this is very much not for static, and for
dhcp this filter is ignored by the installer.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index e6c1bd0..477a71f 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -400,8 +400,8 @@ pub fn render_network_options_form(
.name("netif-name-pinning-enabled")
.default(config.netif_name_pinning_enabled),
)
- .with_advanced_spacer()
- .with_advanced_field(
+ .with_spacer()
+ .with_field(
tr!("Network Device Filters"),
KeyValueList::new()
.value(
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab
2026-05-27 7:56 [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
@ 2026-05-27 8:02 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-05-27 8:02 UTC (permalink / raw)
To: pdm-devel, Hannes Laimer
On Wed, 27 May 2026 09:56:06 +0200, Hannes Laimer wrote:
> We don't show the advanced checkbox, so having the filter in the
> advanced section will always have it hidden. This prevents submitting
> cause the filter is required for static ip configurations. The disks
> form has the same scenario, "advanced filtering" required based on form
> input.
>
> Not having it in advanced also makes sense cause advanced usually
> implies optionality, which this is very much not for static, and for
> dhcp this filter is ignored by the installer.
>
> [...]
Applied, thanks!
[1/1] ui: auto-installer: align network-tab with disks-tab
commit: a52f563f73228d9ef7b2c2fe6bae3403c065bacf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-27 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27 7:56 [PATCH datacenter-manager v2] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
2026-05-27 8:02 ` applied: " Dominik Csapak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.