* [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list"
@ 2026-05-18 13:23 Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 1/3] ui: add translation notes for prefix lists Shannon Sterz
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Shannon Sterz @ 2026-05-18 13:23 UTC (permalink / raw)
To: pve-devel
adds some context for translator when it comes to translating the frr
terms "route map" and "prefix list".
also aligns the capitalization of "prefix list".
Changelog
---------
changes since v1:
* fixed-up mangeled line in patch 1
* added a patch to fix the capitalization of "prefix list" (thanks @
Gabriel Goller)
Shannon Sterz (3):
ui: add translation notes for prefix lists
ui: add translation notes for route maps
ui: prefix panel: adjust capitalization of "prefix list"
www/manager6/dc/Config.js | 6 ++++
www/manager6/sdn/PrefixListPanel.js | 28 +++++++++++++++++--
www/manager6/sdn/RouteMapPanel.js | 12 ++++++++
www/manager6/sdn/controllers/BgpEdit.js | 6 ++++
www/manager6/sdn/controllers/EvpnEdit.js | 6 ++++
.../sdn/fabrics/RedistributionGrid.js | 3 ++
www/manager6/sdn/fabrics/bgp/FabricEdit.js | 12 ++++++++
7 files changed, 70 insertions(+), 3 deletions(-)
--
2.47.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH manager v2 1/3] ui: add translation notes for prefix lists
2026-05-18 13:23 [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list" Shannon Sterz
@ 2026-05-18 13:23 ` Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 2/3] ui: add translation notes for route maps Shannon Sterz
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Shannon Sterz @ 2026-05-18 13:23 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
---
www/manager6/dc/Config.js | 3 +++
www/manager6/sdn/PrefixListPanel.js | 22 ++++++++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 954e0791a..6611061d0 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -320,6 +320,9 @@ Ext.define('PVE.dc.Config', {
{
xtype: 'pveSDNPrefixLists',
groups: ['sdn'],
+ // TRANSLATORS: Refers to an FRR prefix list, some
+ // languages may prefer to keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
title: gettext('Prefix Lists'),
hidden: true,
iconCls: 'fa fa-list-ol',
diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
index 451ff9646..05ec3655a 100644
--- a/www/manager6/sdn/PrefixListPanel.js
+++ b/www/manager6/sdn/PrefixListPanel.js
@@ -11,6 +11,10 @@ Ext.define('PVE.sdn.PrefixListEntry', {
Ext.define('PVE.sdn.EditPrefixListWindow', {
extend: 'Proxmox.window.Edit',
+
+ // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+ // keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
subject: gettext('Prefix List'),
url: '/cluster/sdn/prefix-lists',
@@ -42,6 +46,9 @@ Ext.define('PVE.sdn.EditPrefixListEntryWindow', {
extend: 'Proxmox.window.Edit',
mixins: ['Proxmox.Mixin.CBind'],
+ // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+ // keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
subject: gettext('Prefix List Entry'),
baseUrl: '/cluster/sdn/prefix-lists',
@@ -126,6 +133,9 @@ Ext.define('PVE.sdn.PrefixListView', {
extend: 'Ext.grid.GridPanel',
alias: ['widget.pveSDNPrefixListView'],
+ // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+ // keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
emptyText: gettext('No prefix list configured'),
tbar: [
@@ -188,6 +198,9 @@ Ext.define('PVE.sdn.PrefixListEntriesView', {
extend: 'Ext.grid.GridPanel',
alias: ['widget.pveSDNPrefixListEntriesView'],
+ // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+ // keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
emptyText: gettext('Prefix List has no entries configured.'),
config: {
@@ -279,6 +292,9 @@ Ext.define('PVE.sdn.PrefixListPanel', {
extend: 'Ext.panel.Panel',
alias: ['widget.pveSDNPrefixLists'],
+ // TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
+ // keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
emptyText: gettext('No prefix list configured'),
viewModel: {
@@ -287,7 +303,13 @@ Ext.define('PVE.sdn.PrefixListPanel', {
let selection = get('prefixListGrid.selection');
return selection
+ // TRANSLATORS: Refers to an FRR prefix list, some
+ // languages may prefer to keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
? gettext('Prefix List has no entries configured.')
+ // TRANSLATORS: Refers to an FRR prefix list, some
+ // languages may prefer to keep "prefix list" as-is:
+ // https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
: gettext('no Prefix List selected');
},
},
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH manager v2 2/3] ui: add translation notes for route maps
2026-05-18 13:23 [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list" Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 1/3] ui: add translation notes for prefix lists Shannon Sterz
@ 2026-05-18 13:23 ` Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 3/3] ui: prefix panel: adjust capitalization of "prefix list" Shannon Sterz
2026-05-18 20:06 ` applied: [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Shannon Sterz @ 2026-05-18 13:23 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
---
www/manager6/dc/Config.js | 3 +++
www/manager6/sdn/RouteMapPanel.js | 12 ++++++++++++
www/manager6/sdn/controllers/BgpEdit.js | 6 ++++++
www/manager6/sdn/controllers/EvpnEdit.js | 6 ++++++
www/manager6/sdn/fabrics/RedistributionGrid.js | 3 +++
www/manager6/sdn/fabrics/bgp/FabricEdit.js | 12 ++++++++++++
6 files changed, 42 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 6611061d0..d303c8c03 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -312,6 +312,9 @@ Ext.define('PVE.dc.Config', {
{
xtype: 'pveSDNRouteMaps',
groups: ['sdn'],
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
title: gettext('Route Maps'),
hidden: true,
iconCls: 'fa fa-map',
diff --git a/www/manager6/sdn/RouteMapPanel.js b/www/manager6/sdn/RouteMapPanel.js
index 71464d435..4e6081289 100644
--- a/www/manager6/sdn/RouteMapPanel.js
+++ b/www/manager6/sdn/RouteMapPanel.js
@@ -697,6 +697,9 @@ Ext.define('PVE.sdn.RouteMapExitActionField', {
Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
extend: 'Proxmox.window.Edit',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some languages may
+ // prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
subject: gettext('Route Map Entry'),
initComponent: function () {
@@ -747,6 +750,9 @@ Ext.define('PVE.sdn.EditRouteMapEntryWindow', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-id',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Route Map ID'),
editable: true,
notFoundIsValid: true,
@@ -811,6 +817,9 @@ Ext.define('PVE.sdn.RouteMapPanel', {
extend: 'Ext.grid.Panel',
alias: ['widget.pveSDNRouteMaps'],
+ // TRANSLATORS: "Route map" refers to an FRR route map, some languages may
+ // prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
emptyText: gettext('No route maps configured.'),
store: {
@@ -878,6 +887,9 @@ Ext.define('PVE.sdn.RouteMapPanel', {
Ext.Msg.show({
title: gettext('Confirm'),
icon: Ext.Msg.WARNING,
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
message: gettext('Remove route map entry?'),
buttons: Ext.Msg.YESNO,
defaultFocus: 'no',
diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 8cad01ceb..f587c4039 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -76,6 +76,9 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Incoming Route Map'),
deleteEmpty: !me.isCreate,
skipEmptyText: true,
@@ -83,6 +86,9 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Outgoing Route Map'),
deleteEmpty: !me.isCreate,
skipEmptyText: true,
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index eb3c119ca..46e4ab735 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -67,6 +67,9 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Incoming Route Map'),
deleteEmpty: !me.isCreate,
skipEmptyText: true,
@@ -74,6 +77,9 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Outgoing Route Map'),
deleteEmpty: !me.isCreate,
skipEmptyText: true,
diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js
index 846ecef0c..77dd77827 100644
--- a/www/manager6/sdn/fabrics/RedistributionGrid.js
+++ b/www/manager6/sdn/fabrics/RedistributionGrid.js
@@ -97,6 +97,9 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
},
},
{
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
text: gettext('Route Map'),
xtype: 'widgetcolumn',
dataIndex: 'route-map',
diff --git a/www/manager6/sdn/fabrics/bgp/FabricEdit.js b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
index 40941b5aa..15fc52a51 100644
--- a/www/manager6/sdn/fabrics/bgp/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/bgp/FabricEdit.js
@@ -32,8 +32,14 @@ Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route_map_in',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Incoming Route Map'),
labelWidth: 120,
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
emptyText: gettext('Route Map'),
deleteEmpty: true,
skipEmptyText: true,
@@ -41,8 +47,14 @@ Ext.define('PVE.sdn.Fabric.Bgp.Fabric.Edit', {
{
xtype: 'pveSDNRouteMapSelector',
name: 'route_map_out',
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
fieldLabel: gettext('Outgoing Route Map'),
labelWidth: 120,
+ // TRANSLATORS: "Route map" refers to an FRR route map, some
+ // languages may prefer to keep it as-is:
+ // https://docs.frrouting.org/en/latest/routemap.html
emptyText: gettext('Route Map'),
deleteEmpty: true,
skipEmptyText: true,
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH manager v2 3/3] ui: prefix panel: adjust capitalization of "prefix list"
2026-05-18 13:23 [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list" Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 1/3] ui: add translation notes for prefix lists Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 2/3] ui: add translation notes for route maps Shannon Sterz
@ 2026-05-18 13:23 ` Shannon Sterz
2026-05-18 20:06 ` applied: [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align " Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Shannon Sterz @ 2026-05-18 13:23 UTC (permalink / raw)
To: pve-devel
"prefix list" is not a proper noun and as such should follow regular
english capitalization rules. this is in-line with how frr treats this
term [1].
[1]: https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
Suggested-by: Gabriel Goller <g.goller@proxmox.com>
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
www/manager6/sdn/PrefixListPanel.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/sdn/PrefixListPanel.js b/www/manager6/sdn/PrefixListPanel.js
index 05ec3655a..f1a406acc 100644
--- a/www/manager6/sdn/PrefixListPanel.js
+++ b/www/manager6/sdn/PrefixListPanel.js
@@ -201,7 +201,7 @@ Ext.define('PVE.sdn.PrefixListEntriesView', {
// TRANSLATORS: Refers to an FRR prefix list, some languages may prefer to
// keep "prefix list" as-is:
// https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
- emptyText: gettext('Prefix List has no entries configured.'),
+ emptyText: gettext('Prefix list has no entries configured.'),
config: {
prefixList: null,
@@ -306,11 +306,11 @@ Ext.define('PVE.sdn.PrefixListPanel', {
// TRANSLATORS: Refers to an FRR prefix list, some
// languages may prefer to keep "prefix list" as-is:
// https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
- ? gettext('Prefix List has no entries configured.')
+ ? gettext('Prefix list has no entries configured.')
// TRANSLATORS: Refers to an FRR prefix list, some
// languages may prefer to keep "prefix list" as-is:
// https://docs.frrouting.org/en/latest/filter.html#ip-prefix-list
- : gettext('no Prefix List selected');
+ : gettext('No prefix list selected');
},
},
},
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* applied: [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list"
2026-05-18 13:23 [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list" Shannon Sterz
` (2 preceding siblings ...)
2026-05-18 13:23 ` [PATCH manager v2 3/3] ui: prefix panel: adjust capitalization of "prefix list" Shannon Sterz
@ 2026-05-18 20:06 ` Thomas Lamprecht
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2026-05-18 20:06 UTC (permalink / raw)
To: pve-devel, Shannon Sterz
On Mon, 18 May 2026 15:23:44 +0200, Shannon Sterz wrote:
> adds some context for translator when it comes to translating the frr
> terms "route map" and "prefix list".
>
> also aligns the capitalization of "prefix list".
>
> Changelog
> ---------
>
> [...]
Applied, thanks!
[1/3] ui: add translation notes for prefix lists
commit: d50dac44186db52992ddaa84c608fb23a4702527
[2/3] ui: add translation notes for route maps
commit: e1b54e63791e78c54fe152e42273491d10210afa
[3/3] ui: prefix panel: adjust capitalization of "prefix list"
commit: 4297427a321b7c6a9a68785c460db6d5a4f7dee4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-18 20:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-18 13:23 [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align capitalization of "prefix list" Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 1/3] ui: add translation notes for prefix lists Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 2/3] ui: add translation notes for route maps Shannon Sterz
2026-05-18 13:23 ` [PATCH manager v2 3/3] ui: prefix panel: adjust capitalization of "prefix list" Shannon Sterz
2026-05-18 20:06 ` applied: [PATCH manager v2 0/3] add translation notes for prefix lists and route maps; align " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.