[PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive

[PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive

[Dominik Csapak]

The MultiDiskPanel recently changed to only add the first disk in
afterrender to make sure we have a nodename to determine the
architecture of the vm (for architecture specific defaults).

In contrast the os panel in the wizard assumed the first disk was
already added and changed the controller value based on e.g. if there is
a second cd drive for windows virtio drivers (set it to scsi in that
case).

For that to work, the disk has to be added sooner. The first available
point in time is when we add set the nodename the first time to a truthy
value, so do it there instead (and save that information to not add a
disk on every setNodename, only the first valid one).

This fixes the issue that the disk controller was still set to IDE in
case the user added a second cd drive for virtio drivers.

Fixes: 6be73bfe (ui: qemu: make sortByPreviousUsage architecture aware)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/panel/MultiDiskEdit.js | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/www/manager6/panel/MultiDiskEdit.js b/www/manager6/panel/MultiDiskEdit.js
index e96a5f96..3de07674 100644
--- a/www/manager6/panel/MultiDiskEdit.js
+++ b/www/manager6/panel/MultiDiskEdit.js
@@ -4,10 +4,19 @@ Ext.define('PVE.panel.MultiDiskPanel', {
     mixins: ['Proxmox.Mixin.CBind'],
 
     setNodename: function (nodename) {
-        this.items.each((panel) => panel.setNodename(nodename));
-        this.nodename = nodename;
+        let me = this;
+        me.items.each((panel) => panel.setNodename(nodename));
+        me.nodename = nodename;
+
+        if (!me.addedFirstDisk && !!nodename) {
+            let controller = me.getController();
+            controller.onAdd();
+            me.lookup('grid').getSelectionModel().select(0, false);
+        }
     },
 
+    addedFirstDisk: false,
+
     border: false,
     bodyBorder: false,
 
@@ -21,7 +30,12 @@ Ext.define('PVE.panel.MultiDiskPanel', {
         vmconfig: {},
 
         onAdd: function () {
-            this.addDiskChecked(false);
+            let me = this;
+            let view = me.getView();
+            me.addDiskChecked(false);
+            if (!view.addedFirstDisk) {
+                view.addedFirstDisk = true;
+            }
         },
 
         onImport: function () {
@@ -211,13 +225,6 @@ Ext.define('PVE.panel.MultiDiskPanel', {
             'grid[reference=grid]': {
                 selectionchange: 'onSelectionChange',
             },
-            '#': {
-                afterrender: function (view) {
-                    let me = this;
-                    me.onAdd();
-                    me.lookup('grid').getSelectionModel().select(0, false);
-                },
-            },
         },
     },
 
-- 
2.47.3

Re: [PATCH manager] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive

[Thomas Lamprecht]

On Mon, 18 May 2026 10:24:05 +0200, Dominik Csapak wrote:
> The MultiDiskPanel recently changed to only add the first disk in
> afterrender to make sure we have a nodename to determine the
> architecture of the vm (for architecture specific defaults).
> 
> In contrast the os panel in the wizard assumed the first disk was
> already added and changed the controller value based on e.g. if there is
> a second cd drive for windows virtio drivers (set it to scsi in that
> case).
> 
> [...]

Applied, thanks!

[1/1] fix #7599: ui: qemu: wizard: fix disk controller for windows with second cd drive
      commit: aecf27bdce984de3516691e5df7e7528b1b3c78d