From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v6 16/21] ui: cpu model selector: allow filtering out custom and builtin models
Date: Mon, 18 May 2026 08:45:21 +0200 [thread overview]
Message-ID: <20260518064526.117067-17-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260518064526.117067-1-a.bied-charreton@proxmox.com>
Add 'showCustomModels' configuration parameter. When set to false, only
default CPU models will be shown.
This is needed when using the CPUModelSelector in the context of
creating a new custom CPU model, where we only want to allow
reported-model values that will be accepted by QEMU.
Based on patch by Stefan Reiter:
https://lore.proxmox.com/pve-devel/20211028114150.3245864-8-s.reiter@proxmox.com/
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/form/CPUModelSelector.js | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js
index a55d473e..d19a09db 100644
--- a/www/manager6/form/CPUModelSelector.js
+++ b/www/manager6/form/CPUModelSelector.js
@@ -17,8 +17,12 @@ Ext.define('PVE.form.CPUModelSelector', {
anyMatch: true,
forceSelection: true,
autoSelect: false,
+ triggerAction: 'query',
deleteEmpty: true,
+ config: {
+ showCustomModels: true,
+ },
getSubmitData: function () {
let me = this,
@@ -135,4 +139,11 @@ Ext.define('PVE.form.CPUModelSelector', {
},
},
},
+ initComponent: function () {
+ let me = this;
+ me.callParent();
+ if (!me.showCustomModels) {
+ me.getStore().addFilter({ filterFn: (rec) => !rec.data.custom && !rec.data.builtin });
+ }
+ },
});
--
2.47.3
next prev parent reply other threads:[~2026-05-18 6:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 6:45 [PATCH manager/qemu-server v6 00/21] Add API and UI for custom CPU models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 01/21] cpu config: rename CPU models config path variable Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 02/21] cpu flags: move cpu flags-related utilities to their own module Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 03/21] cpu flags: compare against JSON::true when querying supported flags Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 04/21] cpu flags: normalize CPU flags to QEMU's format Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 05/21] cpu flags: add helper querying CPU flags with nodes supporting them Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 06/21] cpu config: rename custom CPU model config loader Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 07/21] cpu config: add helpers to lock and write config Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 08/21] cpu: register standard option for CPU format Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 09/21] api: cpu flags: improve flags list returned by endpoint Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 10/21] custom cpu models: avoid redundant config load Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH qemu-server v6 11/21] cpu models: add 'builtin' flag to CPU model list endpoint Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 12/21] cluster: reorder imports Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 13/21] cluster: makefile: reorder perl sources and align backslashes Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 14/21] api: add endpoint querying available CPU flags cluster-wide Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 15/21] api: add CRUD handlers for custom CPU models Arthur Bied-Charreton
2026-05-18 6:45 ` Arthur Bied-Charreton [this message]
2026-05-18 6:45 ` [PATCH pve-manager v6 17/21] ui: add basic custom CPU model editor Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 18/21] ui: cpu flags selector: add CPU flag editor for custom models Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 19/21] ui: cpu flags selector: allow filtering out flags supported on 0 nodes Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 20/21] ui: cpu flags selector: add search bar for large lists of flags Arthur Bied-Charreton
2026-05-18 6:45 ` [PATCH pve-manager v6 21/21] ui: group custom CPU with resource mappings Arthur Bied-Charreton
2026-05-18 8:00 ` [PATCH manager/qemu-server v6 00/21] Add API and UI for custom CPU models Thomas Lamprecht
2026-05-18 8:03 ` Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518064526.117067-17-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.