From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BC1901FF136 for ; Mon, 18 May 2026 08:50:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 757422E90; Mon, 18 May 2026 08:50:53 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v6 16/21] ui: cpu model selector: allow filtering out custom and builtin models Date: Mon, 18 May 2026 08:45:21 +0200 Message-ID: <20260518064526.117067-17-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518064526.117067-1-a.bied-charreton@proxmox.com> References: <20260518064526.117067-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: YJTGXTNLFYH7RKCBWQGSYVDETGJOTAZA X-Message-ID-Hash: YJTGXTNLFYH7RKCBWQGSYVDETGJOTAZA X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add 'showCustomModels' configuration parameter. When set to false, only default CPU models will be shown. This is needed when using the CPUModelSelector in the context of creating a new custom CPU model, where we only want to allow reported-model values that will be accepted by QEMU. Based on patch by Stefan Reiter: https://lore.proxmox.com/pve-devel/20211028114150.3245864-8-s.reiter@proxmox.com/ Signed-off-by: Arthur Bied-Charreton Reviewed-by: Fiona Ebner --- www/manager6/form/CPUModelSelector.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js index a55d473e..d19a09db 100644 --- a/www/manager6/form/CPUModelSelector.js +++ b/www/manager6/form/CPUModelSelector.js @@ -17,8 +17,12 @@ Ext.define('PVE.form.CPUModelSelector', { anyMatch: true, forceSelection: true, autoSelect: false, + triggerAction: 'query', deleteEmpty: true, + config: { + showCustomModels: true, + }, getSubmitData: function () { let me = this, @@ -135,4 +139,11 @@ Ext.define('PVE.form.CPUModelSelector', { }, }, }, + initComponent: function () { + let me = this; + me.callParent(); + if (!me.showCustomModels) { + me.getStore().addFilter({ filterFn: (rec) => !rec.data.custom && !rec.data.builtin }); + } + }, }); -- 2.47.3