From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create
Date: Wed, 13 May 2026 17:36:54 +0200 [thread overview]
Message-ID: <20260513153656.407423-1-s.hanreich@proxmox.com> (raw)
Otherwise this causes an error on trying to create a EVPN / BGP
controller without any route map.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
www/manager6/.lint-incremental | 0
www/manager6/sdn/controllers/BgpEdit.js | 4 ++--
www/manager6/sdn/controllers/EvpnEdit.js | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 www/manager6/.lint-incremental
diff --git a/www/manager6/.lint-incremental b/www/manager6/.lint-incremental
new file mode 100644
index 000000000..e69de29bb
diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 09b001f5f..8cad01ceb 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
fieldLabel: gettext('Incoming Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
fieldLabel: gettext('Outgoing Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
];
diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js
index 2d728f845..ae0c5a646 100644
--- a/www/manager6/sdn/controllers/EvpnEdit.js
+++ b/www/manager6/sdn/controllers/EvpnEdit.js
@@ -68,14 +68,14 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', {
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-in',
fieldLabel: gettext('Incoming Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
xtype: 'pveSDNRouteMapSelector',
name: 'route-map-out',
fieldLabel: gettext('Outgoing Route Map'),
- deleteEmpty: true,
+ deleteEmpty: !me.isCreate,
skipEmptyText: true,
},
{
--
2.47.3
next reply other threads:[~2026-05-13 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 15:36 Stefan Hanreich [this message]
2026-05-15 8:49 ` applied: [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513153656.407423-1-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.