From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0AD951FF13A for ; Wed, 13 May 2026 17:37:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB996169A4; Wed, 13 May 2026 17:37:06 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 1/1] sdn: evpn/bgp controller: dont send empty route-map{in,out} on create Date: Wed, 13 May 2026 17:36:54 +0200 Message-ID: <20260513153656.407423-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778686619107 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.604 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: POXN5MTGRMUNXY3BDYQZTUT6O5YKBLOI X-Message-ID-Hash: POXN5MTGRMUNXY3BDYQZTUT6O5YKBLOI X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise this causes an error on trying to create a EVPN / BGP controller without any route map. Signed-off-by: Stefan Hanreich --- www/manager6/.lint-incremental | 0 www/manager6/sdn/controllers/BgpEdit.js | 4 ++-- www/manager6/sdn/controllers/EvpnEdit.js | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 www/manager6/.lint-incremental diff --git a/www/manager6/.lint-incremental b/www/manager6/.lint-incremental new file mode 100644 index 000000000..e69de29bb diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js index 09b001f5f..8cad01ceb 100644 --- a/www/manager6/sdn/controllers/BgpEdit.js +++ b/www/manager6/sdn/controllers/BgpEdit.js @@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', { xtype: 'pveSDNRouteMapSelector', name: 'route-map-in', fieldLabel: gettext('Incoming Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, { xtype: 'pveSDNRouteMapSelector', name: 'route-map-out', fieldLabel: gettext('Outgoing Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, ]; diff --git a/www/manager6/sdn/controllers/EvpnEdit.js b/www/manager6/sdn/controllers/EvpnEdit.js index 2d728f845..ae0c5a646 100644 --- a/www/manager6/sdn/controllers/EvpnEdit.js +++ b/www/manager6/sdn/controllers/EvpnEdit.js @@ -68,14 +68,14 @@ Ext.define('PVE.sdn.controllers.EvpnInputPanel', { xtype: 'pveSDNRouteMapSelector', name: 'route-map-in', fieldLabel: gettext('Incoming Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, { xtype: 'pveSDNRouteMapSelector', name: 'route-map-out', fieldLabel: gettext('Outgoing Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, { -- 2.47.3