From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH container 7/8] volume rescan: also consider volumes listed only with an approximate size
Date: Wed, 13 May 2026 15:05:39 +0200 [thread overview]
Message-ID: <20260513130548.143270-8-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260513130548.143270-1-f.ebner@proxmox.com>
While currently qcow2 volumes on LVM are the only ones for which an
approximate size might be returned instead of an exact size when
listing the volumes, there might be more storages doing this in the
future, so prepare for that.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/LXC.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 2b3acdd..de8f22e 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2688,9 +2688,9 @@ sub update_disksize {
my $update_mp = sub {
my ($key, $mp, @param) = @_;
- my $size = $all_volumes->{ $mp->{volume} }->{size} // 0;
+ my $size = $all_volumes->{ $mp->{volume} }->{size};
- if (!defined($mp->{size}) || $size != $mp->{size}) {
+ if (defined($size) && (!defined($mp->{size}) || $size != $mp->{size})) {
$changes = 1;
print "$prefix updated volume size of '$mp->{volume}' in config.\n";
$mp->{size} = $size;
@@ -2761,7 +2761,7 @@ sub scan_volids {
foreach my $storeid (keys %$info) {
foreach my $item (@{ $info->{$storeid} }) {
my $volid = $item->{volid};
- next if !($volid && defined($item->{size}));
+ next if !($volid && (defined($item->{size}) || defined($item->{'approximate-size'})));
$item->{path} = PVE::Storage::path($cfg, $volid);
$all_volumes->{$volid} = $item;
}
--
2.47.3
next prev parent reply other threads:[~2026-05-13 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 13:05 [PATCH-SERIES storage/manager/container/qemu-server 0/8] fix #6819: lvm plugin: list images: use approximate size for inactive qcow2 volumes Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 1/8] api: content: add missing imports and group/order according to style guide Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 2/8] pvesm: " Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 3/8] api/cli: list content: declare size optional and add approximate-size Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 4/8] fix #6819: lvm plugin: list images: use approximate size for inactive qcow2 volumes Fiona Ebner
2026-05-13 13:05 ` [PATCH manager 5/8] fix #6819: storage: content view: fallback to approximate size Fiona Ebner
2026-05-13 13:05 ` [PATCH container 6/8] volume rescan: also consider zero-sized volumes Fiona Ebner
2026-05-13 13:05 ` Fiona Ebner [this message]
2026-05-13 13:05 ` [PATCH qemu-server 8/8] volume rescan: also consider volumes listed only with an approximate size Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513130548.143270-8-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.