From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 37D591FF13A for ; Wed, 13 May 2026 15:07:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 499D3E0A4; Wed, 13 May 2026 15:06:47 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH container 7/8] volume rescan: also consider volumes listed only with an approximate size Date: Wed, 13 May 2026 15:05:39 +0200 Message-ID: <20260513130548.143270-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513130548.143270-1-f.ebner@proxmox.com> References: <20260513130548.143270-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778677548230 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3IK6TGHT22AKXDDUMGOBDTD5XFZBJJAG X-Message-ID-Hash: 3IK6TGHT22AKXDDUMGOBDTD5XFZBJJAG X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While currently qcow2 volumes on LVM are the only ones for which an approximate size might be returned instead of an exact size when listing the volumes, there might be more storages doing this in the future, so prepare for that. Signed-off-by: Fiona Ebner --- src/PVE/LXC.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 2b3acdd..de8f22e 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -2688,9 +2688,9 @@ sub update_disksize { my $update_mp = sub { my ($key, $mp, @param) = @_; - my $size = $all_volumes->{ $mp->{volume} }->{size} // 0; + my $size = $all_volumes->{ $mp->{volume} }->{size}; - if (!defined($mp->{size}) || $size != $mp->{size}) { + if (defined($size) && (!defined($mp->{size}) || $size != $mp->{size})) { $changes = 1; print "$prefix updated volume size of '$mp->{volume}' in config.\n"; $mp->{size} = $size; @@ -2761,7 +2761,7 @@ sub scan_volids { foreach my $storeid (keys %$info) { foreach my $item (@{ $info->{$storeid} }) { my $volid = $item->{volid}; - next if !($volid && defined($item->{size})); + next if !($volid && (defined($item->{size}) || defined($item->{'approximate-size'}))); $item->{path} = PVE::Storage::path($cfg, $volid); $all_volumes->{$volid} = $item; } -- 2.47.3