From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH proxmox-backup v3 2/6] fix #6691: allow search by comment in datastore content
Date: Thu, 7 May 2026 10:57:23 +0200 [thread overview]
Message-ID: <20260507085728.11852-3-e.fastermann@proxmox.com> (raw)
In-Reply-To: <20260507085728.11852-1-e.fastermann@proxmox.com>
Using case-insensitive matching.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
changes since v2:
* split out search by comment as separate commit,
detached from case insensitive search on all fields
www/datastore/Content.js | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 8bf2356d4..e7240832a 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -941,6 +941,13 @@ Ext.define('PBS.DataStoreContent', {
return true;
}
+ if (
+ item.data.comment &&
+ item.data.comment.toLowerCase().includes(value.toLowerCase())
+ ) {
+ return true;
+ }
+
return false;
},
@@ -1490,7 +1497,7 @@ Ext.define('PBS.DataStoreContent', {
{
xtype: 'textfield',
reference: 'searchbox',
- emptyText: gettext('group, date or owner'),
+ emptyText: gettext('group, date, owner or comment'),
triggers: {
clear: {
cls: 'pmx-clear-trigger',
--
2.47.3
next prev parent reply other threads:[~2026-05-07 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 8:57 [PATCH proxmox-backup v3 0/6] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 1/6] ui: datastore: update code formatting with biome Erik Fastermann
2026-05-07 8:57 ` Erik Fastermann [this message]
2026-05-07 8:57 ` [PATCH proxmox-backup v3 3/6] ui: datastore: case-insensitive search on all content fields Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 4/6] ui: datastore: disable remove action for namespaces Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 5/6] ui: datastore: disable browse action for root ns Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 6/6] ui: datastore: fix content search empty tree Erik Fastermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507085728.11852-3-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.