From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3293A1FF13F for ; Thu, 07 May 2026 10:57:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EBE710329; Thu, 7 May 2026 10:57:33 +0200 (CEST) From: Erik Fastermann To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v3 2/6] fix #6691: allow search by comment in datastore content Date: Thu, 7 May 2026 10:57:23 +0200 Message-ID: <20260507085728.11852-3-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260507085728.11852-1-e.fastermann@proxmox.com> References: <20260507085728.11852-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: CWW4YLSSJF62ENL7T32LKCSBLLRW62C3 X-Message-ID-Hash: CWW4YLSSJF62ENL7T32LKCSBLLRW62C3 X-MailFrom: root@erik-test-pbs.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Using case-insensitive matching. Signed-off-by: Erik Fastermann --- changes since v2: * split out search by comment as separate commit, detached from case insensitive search on all fields www/datastore/Content.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/datastore/Content.js b/www/datastore/Content.js index 8bf2356d4..e7240832a 100644 --- a/www/datastore/Content.js +++ b/www/datastore/Content.js @@ -941,6 +941,13 @@ Ext.define('PBS.DataStoreContent', { return true; } + if ( + item.data.comment && + item.data.comment.toLowerCase().includes(value.toLowerCase()) + ) { + return true; + } + return false; }, @@ -1490,7 +1497,7 @@ Ext.define('PBS.DataStoreContent', { { xtype: 'textfield', reference: 'searchbox', - emptyText: gettext('group, date or owner'), + emptyText: gettext('group, date, owner or comment'), triggers: { clear: { cls: 'pmx-clear-trigger', -- 2.47.3