all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH novnc] upgrade noVNC and patches to 1.7.0
@ 2026-05-07  7:25 Dominik Csapak
  2026-05-07  9:55 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-05-07  7:25 UTC (permalink / raw)
  To: pve-devel

drop the backport of
 f0a39cd (Fix appearance of extra key buttons)
since it's included now.

and refresh/rebase the patches (including some light whitespace fixes).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---

needs an update of our novnc git mirror

 .../0001-add-PVE-specific-JS-code.patch       |  6 +-
 ...002-add-custom-fbresize-event-on-rfb.patch | 10 ++--
 ...nge-scaling-when-toggling-fullscreen.patch |  8 +--
 debian/patches/0004-add-pve-style.patch       |  8 +--
 debian/patches/0005-remove-vnc-logos.patch    |  2 +-
 ...rectory-for-fetching-images-js-files.patch |  4 +-
 .../patches/0007-add-pve-vnc-commands.patch   |  2 +-
 ...add-replaceable-snippets-in-vnc.html.patch |  2 +-
 .../0009-decrease-animation-time.patch        |  4 +-
 debian/patches/0010-use-only-app.js.patch     |  2 +-
 .../0011-add-localCursor-setting-to-rfb.patch | 12 ++--
 .../0012-pass-custom-command-to-vnc.patch     |  2 +-
 ...ove-the-default-value-of-wsProtocols.patch |  8 +--
 ...passing-deprecated-upgrade-parameter.patch |  2 +-
 ...-create-own-class-for-hidden-buttons.patch | 11 ++--
 ...-button-on-isFullscreen-get-variable.patch |  2 +-
 debian/patches/0017-make-error-hideable.patch | 28 ++++-----
 ...ow-start-button-on-not-running-vm-ct.patch | 11 ++--
 .../patches/0019-show-clipboard-button.patch  |  2 +-
 ...-Fix-appearance-of-extra-key-buttons.patch | 60 -------------------
 ...atch => 0020-use-generated-password.patch} |  3 +
 debian/patches/series                         |  3 +-
 novnc                                         |  2 +-
 23 files changed, 68 insertions(+), 126 deletions(-)
 delete mode 100644 debian/patches/0020-Fix-appearance-of-extra-key-buttons.patch
 rename debian/patches/{0021-use-generated-password.patch => 0020-use-generated-password.patch} (98%)

diff --git a/debian/patches/0001-add-PVE-specific-JS-code.patch b/debian/patches/0001-add-PVE-specific-JS-code.patch
index 926f0c0..f5bb262 100644
--- a/debian/patches/0001-add-PVE-specific-JS-code.patch
+++ b/debian/patches/0001-add-PVE-specific-JS-code.patch
@@ -453,7 +453,7 @@ index 0000000..1a062ad
 +    },
 +};
 diff --git a/app/ui.js b/app/ui.js
-index 51e57bd..bd1561c 100644
+index 8434a51..cba90b6 100644
 --- a/app/ui.js
 +++ b/app/ui.js
 @@ -17,6 +17,7 @@ import keysyms from "../core/input/keysymdef.js";
@@ -562,7 +562,7 @@ index 51e57bd..bd1561c 100644
      },
  
  /* ------^-------
-@@ -1729,9 +1750,36 @@ const UI = {
+@@ -1751,9 +1772,36 @@ const UI = {
  /* ------^-------
   *   /EXTRA KEYS
   * ==============
@@ -638,5 +638,5 @@ index 82cacd5..458f4d0 100644
                          <div><ul>
                              <li>
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch b/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch
index 2fd12b0..86a504f 100644
--- a/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch
+++ b/debian/patches/0002-add-custom-fbresize-event-on-rfb.patch
@@ -13,7 +13,7 @@ Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
  2 files changed, 21 insertions(+)
 
 diff --git a/app/ui.js b/app/ui.js
-index bd1561c..3726c8c 100644
+index cba90b6..18d7c36 100644
 --- a/app/ui.js
 +++ b/app/ui.js
 @@ -1116,6 +1116,7 @@ const UI = {
@@ -24,7 +24,7 @@ index bd1561c..3726c8c 100644
          UI.rfb.clipViewport = UI.getSetting('view_clip');
          UI.rfb.scaleViewport = UI.getSetting('resize') === 'scale';
          UI.rfb.resizeSession = UI.getSetting('resize') === 'remote';
-@@ -1775,6 +1776,16 @@ const UI = {
+@@ -1797,6 +1798,16 @@ const UI = {
          document.getElementById('pve_commands_button').classList.remove("noVNC_selected");
      },
  
@@ -42,10 +42,10 @@ index bd1561c..3726c8c 100644
   *    /PVE
   * ==============
 diff --git a/core/rfb.js b/core/rfb.js
-index e3266cc..23b436c 100644
+index 80011e4..4db6e73 100644
 --- a/core/rfb.js
 +++ b/core/rfb.js
-@@ -3014,6 +3014,16 @@ export default class RFB extends EventTargetMixin {
+@@ -3010,6 +3010,16 @@ export default class RFB extends EventTargetMixin {
          this._updateClip();
          this._updateScale();
  
@@ -63,5 +63,5 @@ index e3266cc..23b436c 100644
  
          // Keep this size until browser client size changes
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch b/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch
index b51cddc..f519e16 100644
--- a/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch
+++ b/debian/patches/0003-change-scaling-when-toggling-fullscreen.patch
@@ -12,10 +12,10 @@ Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
  1 file changed, 11 insertions(+)
 
 diff --git a/app/ui.js b/app/ui.js
-index 3726c8c..5773ddf 100644
+index 18d7c36..dbf5f96 100644
 --- a/app/ui.js
 +++ b/app/ui.js
-@@ -1334,6 +1334,13 @@ const UI = {
+@@ -1356,6 +1356,13 @@ const UI = {
              } else if (document.msExitFullscreen) {
                  document.msExitFullscreen();
              }
@@ -29,7 +29,7 @@ index 3726c8c..5773ddf 100644
          } else {
              if (document.documentElement.requestFullscreen) {
                  document.documentElement.requestFullscreen();
-@@ -1344,7 +1351,11 @@ const UI = {
+@@ -1366,7 +1373,11 @@ const UI = {
              } else if (document.body.msRequestFullscreen) {
                  document.body.msRequestFullscreen();
              }
@@ -42,5 +42,5 @@ index 3726c8c..5773ddf 100644
      },
  
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0004-add-pve-style.patch b/debian/patches/0004-add-pve-style.patch
index d0f2592..dfa2685 100644
--- a/debian/patches/0004-add-pve-style.patch
+++ b/debian/patches/0004-add-pve-style.patch
@@ -10,14 +10,14 @@ and fix the z-index of the connect overlay
 
 Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 ---
- app/styles/pve.css | 46 ++++++++++++++++++++++++++++++++++++++++++++++
+ app/styles/pve.css | 50 ++++++++++++++++++++++++++++++++++++++++++++++
  vnc.html           |  1 +
- 2 files changed, 47 insertions(+)
+ 2 files changed, 51 insertions(+)
  create mode 100644 app/styles/pve.css
 
 diff --git a/app/styles/pve.css b/app/styles/pve.css
 new file mode 100644
-index 0000000..a312a95
+index 0000000..ce0c69b
 --- /dev/null
 +++ b/app/styles/pve.css
 @@ -0,0 +1,50 @@
@@ -84,5 +84,5 @@ index 458f4d0..2a50991 100644
      <!-- Images that will later appear via CSS -->
      <link rel="preload" as="image" href="app/images/info.svg">
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0005-remove-vnc-logos.patch b/debian/patches/0005-remove-vnc-logos.patch
index 98a4878..d15e3bf 100644
--- a/debian/patches/0005-remove-vnc-logos.patch
+++ b/debian/patches/0005-remove-vnc-logos.patch
@@ -46,5 +46,5 @@ index 2a50991..f5e4a81 100644
      <link rel="stylesheet" href="app/styles/constants.css">
      <link rel="stylesheet" href="app/styles/base.css">
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch b/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch
index 680f6ea..7277b3d 100644
--- a/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch
+++ b/debian/patches/0006-change-source-directory-for-fetching-images-js-files.patch
@@ -13,7 +13,7 @@ Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
  2 files changed, 33 insertions(+), 34 deletions(-)
 
 diff --git a/app/ui.js b/app/ui.js
-index 5773ddf..01c7c77 100644
+index dbf5f96..d9a8d52 100644
 --- a/app/ui.js
 +++ b/app/ui.js
 @@ -58,7 +58,7 @@ const UI = {
@@ -218,5 +218,5 @@ index f5e4a81..9f4fac0 100644
   </body>
  </html>
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0007-add-pve-vnc-commands.patch b/debian/patches/0007-add-pve-vnc-commands.patch
index ea01382..ee329be 100644
--- a/debian/patches/0007-add-pve-vnc-commands.patch
+++ b/debian/patches/0007-add-pve-vnc-commands.patch
@@ -41,5 +41,5 @@ index 9f4fac0..c9e166c 100644
              <input type="image" alt="Disconnect" src="/novnc/app/images/disconnect.svg"
                  id="noVNC_disconnect_button" class="noVNC_button"
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0008-add-replaceable-snippets-in-vnc.html.patch b/debian/patches/0008-add-replaceable-snippets-in-vnc.html.patch
index 0b171ff..f511dbc 100644
--- a/debian/patches/0008-add-replaceable-snippets-in-vnc.html.patch
+++ b/debian/patches/0008-add-replaceable-snippets-in-vnc.html.patch
@@ -37,5 +37,5 @@ index c9e166c..3c40c49 100644
          import UI from "/novnc/app/ui.js";
          import * as Log from '/novnc/core/util/logging.js';
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0009-decrease-animation-time.patch b/debian/patches/0009-decrease-animation-time.patch
index c5ad05a..44fd7e6 100644
--- a/debian/patches/0009-decrease-animation-time.patch
+++ b/debian/patches/0009-decrease-animation-time.patch
@@ -11,7 +11,7 @@ Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
  1 file changed, 7 insertions(+), 7 deletions(-)
 
 diff --git a/app/styles/base.css b/app/styles/base.css
-index 87bfb45..6e9b25d 100644
+index 33f0f35..fe96001 100644
 --- a/app/styles/base.css
 +++ b/app/styles/base.css
 @@ -223,7 +223,7 @@ html {
@@ -78,5 +78,5 @@ index 87bfb45..6e9b25d 100644
      display: flex;
      opacity: 0;
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0010-use-only-app.js.patch b/debian/patches/0010-use-only-app.js.patch
index 5e64eb8..d26c804 100644
--- a/debian/patches/0010-use-only-app.js.patch
+++ b/debian/patches/0010-use-only-app.js.patch
@@ -73,5 +73,5 @@ index 3c40c49..8ff6739 100644
  </head>
  
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0011-add-localCursor-setting-to-rfb.patch b/debian/patches/0011-add-localCursor-setting-to-rfb.patch
index 62068c6..be2bdb4 100644
--- a/debian/patches/0011-add-localCursor-setting-to-rfb.patch
+++ b/debian/patches/0011-add-localCursor-setting-to-rfb.patch
@@ -15,7 +15,7 @@ Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
  4 files changed, 41 insertions(+), 1 deletion(-)
 
 diff --git a/app/ui.js b/app/ui.js
-index 01c7c77..0434fbc 100644
+index d9a8d52..7b998a0 100644
 --- a/app/ui.js
 +++ b/app/ui.js
 @@ -192,6 +192,7 @@ const UI = {
@@ -43,7 +43,7 @@ index 01c7c77..0434fbc 100644
          UI.rfb.scaleViewport = UI.getSetting('resize') === 'scale';
          UI.rfb.resizeSession = UI.getSetting('resize') === 'remote';
          UI.rfb.qualityLevel = parseInt(UI.getSetting('quality'));
-@@ -1802,6 +1806,12 @@ const UI = {
+@@ -1824,6 +1828,12 @@ const UI = {
   * ==============
   *     MISC
   * ------v------*/
@@ -57,7 +57,7 @@ index 01c7c77..0434fbc 100644
          if (!UI.rfb) return;
          UI.rfb.viewOnly = UI.getSetting('view_only');
 diff --git a/core/rfb.js b/core/rfb.js
-index 23b436c..8260929 100644
+index 4db6e73..5cc2733 100644
 --- a/core/rfb.js
 +++ b/core/rfb.js
 @@ -298,6 +298,7 @@ export default class RFB extends EventTargetMixin {
@@ -67,8 +67,8 @@ index 23b436c..8260929 100644
 +        this._localCursor = false;
  
          this._showDotCursor = false;
-         if (options.showDotCursor !== undefined) {
-@@ -368,6 +369,15 @@ export default class RFB extends EventTargetMixin {
+ 
+@@ -364,6 +365,15 @@ export default class RFB extends EventTargetMixin {
          }
      }
  
@@ -155,5 +155,5 @@ index 8ff6739..f2c29af 100644
                          <label>
                              <input id="noVNC_setting_autoresize" type="checkbox"
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0012-pass-custom-command-to-vnc.patch b/debian/patches/0012-pass-custom-command-to-vnc.patch
index 4c1a190..c71a6c1 100644
--- a/debian/patches/0012-pass-custom-command-to-vnc.patch
+++ b/debian/patches/0012-pass-custom-command-to-vnc.patch
@@ -35,5 +35,5 @@ index 1a062ad..8ce258c 100644
  	default:
  	    throw 'implement me';
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0013-Revert-Remove-the-default-value-of-wsProtocols.patch b/debian/patches/0013-Revert-Remove-the-default-value-of-wsProtocols.patch
index 57c6f74..b52336b 100644
--- a/debian/patches/0013-Revert-Remove-the-default-value-of-wsProtocols.patch
+++ b/debian/patches/0013-Revert-Remove-the-default-value-of-wsProtocols.patch
@@ -16,7 +16,7 @@ Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
  2 files changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/core/rfb.js b/core/rfb.js
-index 8260929..945829b 100644
+index 5cc2733..4d4037a 100644
 --- a/core/rfb.js
 +++ b/core/rfb.js
 @@ -118,7 +118,8 @@ export default class RFB extends EventTargetMixin {
@@ -30,10 +30,10 @@ index 8260929..945829b 100644
          // Internal state
          this._rfbConnectionState = '';
 diff --git a/docs/API.md b/docs/API.md
-index eb3ec33..6616048 100644
+index c1f6fac..47027d7 100644
 --- a/docs/API.md
 +++ b/docs/API.md
-@@ -229,8 +229,7 @@ new RFB(target, urlOrChannel, options);
+@@ -224,8 +224,7 @@ new RFB(target, urlOrChannel, options);
          encountered.
  
      `wsProtocols`
@@ -44,5 +44,5 @@ index eb3ec33..6616048 100644
  #### bell
  
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch b/debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch
index 5f708c4..bdcc5a0 100644
--- a/debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch
+++ b/debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch
@@ -23,5 +23,5 @@ index 8ce258c..873c7b5 100644
  	    break;
  	case 'cmd':
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0015-create-own-class-for-hidden-buttons.patch b/debian/patches/0015-create-own-class-for-hidden-buttons.patch
index 427e60d..ebbd489 100644
--- a/debian/patches/0015-create-own-class-for-hidden-buttons.patch
+++ b/debian/patches/0015-create-own-class-for-hidden-buttons.patch
@@ -9,8 +9,8 @@ class, even if we hid it. This way the buttons stay hidden even then.
 Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 ---
  app/pve.js         | 8 ++++----
- app/styles/pve.css | 4 ++++
- 2 files changed, 8 insertions(+), 4 deletions(-)
+ app/styles/pve.css | 8 ++++++++
+ 2 files changed, 12 insertions(+), 4 deletions(-)
 
 diff --git a/app/pve.js b/app/pve.js
 index 873c7b5..f87f01b 100644
@@ -45,10 +45,10 @@ index 873c7b5..f87f01b 100644
  	});
      },
 diff --git a/app/styles/pve.css b/app/styles/pve.css
-index a312a95..6762325 100644
+index ce0c69b..26c864b 100644
 --- a/app/styles/pve.css
 +++ b/app/styles/pve.css
-@@ -48,3 +48,11 @@
+@@ -48,3 +48,11 @@ input:not(.toggle), button, div:not(#noVNC_container) {
  }
  
   /* noVNC style overrides end */
@@ -61,4 +61,5 @@ index a312a95..6762325 100644
 +
 + /* Custom Proxmox styles end */
 -- 
-2.39.5
+2.47.3
+
diff --git a/debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch b/debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
index b1157d9..5c042c4 100644
--- a/debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
+++ b/debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch
@@ -38,5 +38,5 @@ index f87f01b..368f23a 100644
  	var commandArray = [
  	    { cmd: 'start', kvm: 1, lxc: 1},
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0017-make-error-hideable.patch b/debian/patches/0017-make-error-hideable.patch
index 946683b..b7bfcaa 100644
--- a/debian/patches/0017-make-error-hideable.patch
+++ b/debian/patches/0017-make-error-hideable.patch
@@ -7,14 +7,14 @@ by clicking on it
 
 Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
 ---
- app/error-handler.js | 18 ++++++++++++++++--
- 1 file changed, 16 insertions(+), 2 deletions(-)
+ app/error-handler.js | 18 +++++++++++++++---
+ 1 file changed, 15 insertions(+), 3 deletions(-)
 
 diff --git a/app/error-handler.js b/app/error-handler.js
-index 5f6ffb6..bb233e5 100644
+index ef1cb64..fcd6a60 100644
 --- a/app/error-handler.js
 +++ b/app/error-handler.js
-@@ -6,6 +6,19 @@
+@@ -6,6 +6,18 @@
   * See README.md for usage and integration instructions.
   */
  
@@ -22,30 +22,30 @@ index 5f6ffb6..bb233e5 100644
 +    const msg = document.getElementById('noVNC_fallback_errormsg');
 +
 +    // close it
-+    document.getElementById('noVNC_fallback_error')
-+	.classList.remove("noVNC_open");
++    document.getElementById('noVNC_fallback_error').classList.remove('noVNC_open');
 +
 +    // remove all children
 +    while (msg.firstChild) {
-+	msg.removeChild(msg.firstChild);
++        msg.removeChild(msg.firstChild);
 +    }
 +}
 +
- // Fallback for all uncought errors
+ // Fallback for all uncaught errors
  function handleError(event, err) {
      try {
-@@ -48,8 +61,9 @@ function handleError(event, err) {
+@@ -48,9 +60,9 @@ function handleError(event, err) {
              msg.appendChild(div);
          }
  
 -        document.getElementById('noVNC_fallback_error')
 -            .classList.add("noVNC_open");
-+	const node = document.getElementById('noVNC_fallback_error');
-+	node.classList.add("noVNC_open");
-+	node.onclick = hideError;
- 
+-
++        const node = document.getElementById('noVNC_fallback_error');
++        node.classList.add('noVNC_open');
++        node.onclick = hideError;
      } catch (exc) {
          document.write("noVNC encountered an error.");
+     }
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch b/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
index dd1b526..d9b160d 100644
--- a/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
+++ b/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
@@ -110,14 +110,13 @@ index 368f23a..d7fbdd3 100644
  	var me = this;
  	try {
 diff --git a/app/styles/pve.css b/app/styles/pve.css
-index 6762325..0ce4ebe 100644
+index 26c864b..4f8c9e6 100644
 --- a/app/styles/pve.css
 +++ b/app/styles/pve.css
-@@ -54,5 +54,63 @@ input:not(.toggle), button, div:not(#noVNC_container) {
- .noVNC_button.pve_hidden {
+@@ -55,4 +55,62 @@ input:not(.toggle), button, div:not(#noVNC_container) {
    display: none !important;
  }
-+
+ 
 +/* start button */
 +#pve_start_dlg {
 +  transition: 0.2s ease-in-out;
@@ -175,7 +174,7 @@ index 6762325..0ce4ebe 100644
 +  vertical-align: bottom;
 +  padding: 0 5px 2px 0;
 +}
- 
++
   /* Custom Proxmox styles end */
 diff --git a/vnc.html b/vnc.html
 index f2c29af..4ecb6e0 100644
@@ -198,5 +197,5 @@ index f2c29af..4ecb6e0 100644
      <div class="noVNC_center noVNC_connect_layer">
      <div id="noVNC_credentials_dlg" class="noVNC_panel"><form>
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0019-show-clipboard-button.patch b/debian/patches/0019-show-clipboard-button.patch
index 3a746b1..75b6f1d 100644
--- a/debian/patches/0019-show-clipboard-button.patch
+++ b/debian/patches/0019-show-clipboard-button.patch
@@ -27,5 +27,5 @@ index d7fbdd3..6e69fb6 100644
  		failure: function(msg, code) {
  		    if (code === 403) {
 -- 
-2.39.5
+2.47.3
 
diff --git a/debian/patches/0020-Fix-appearance-of-extra-key-buttons.patch b/debian/patches/0020-Fix-appearance-of-extra-key-buttons.patch
deleted file mode 100644
index 5363835..0000000
--- a/debian/patches/0020-Fix-appearance-of-extra-key-buttons.patch
+++ /dev/null
@@ -1,60 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Samuel Mannehed <samuel@cendio.se>
-Date: Mon, 24 Mar 2025 22:14:43 +0100
-Subject: [PATCH] Fix appearance of extra key buttons
-
-Since the extra keys panel is quite narrow in width, a max-width style
-resulted in the buttons almost disappearing. That rule was only intended
-for elements inside the settings panel.
-
-Broken by commit 14f9ea5880f32f2a4867006d46c8e871942c698e.
-
-Another minor error that is also fixed by this commit is that the
-clipboard textarea no longer incorrectly gets a left margin of 6px.
-
-Fixes #1946.
-
-Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
----
- app/styles/base.css | 18 +++++++++---------
- 1 file changed, 9 insertions(+), 9 deletions(-)
-
-diff --git a/app/styles/base.css b/app/styles/base.css
-index 6e9b25d..0c7c544 100644
---- a/app/styles/base.css
-+++ b/app/styles/base.css
-@@ -475,15 +475,6 @@ html {
-     margin: 5px;
- }
- 
--.noVNC_panel button,
--.noVNC_panel select,
--.noVNC_panel textarea,
--.noVNC_panel input:not([type=checkbox]):not([type=radio]) {
--    margin-left: 6px;
--    /* Prevent inputs in panels from being too wide */
--    max-width: calc(100% - 6px - var(--input-xpadding) * 2);
--}
--
- .noVNC_panel .noVNC_heading {
-     background-color: var(--novnc-blue);
-     border-radius: 6px;
-@@ -621,6 +612,15 @@ html {
-     list-style: none;
-     padding: 0px;
- }
-+#noVNC_settings button,
-+#noVNC_settings select,
-+#noVNC_settings textarea,
-+#noVNC_settings input:not([type=checkbox]):not([type=radio]) {
-+    margin-left: 6px;
-+    /* Prevent inputs in panels from being too wide */
-+    max-width: calc(100% - 6px - var(--input-xpadding) * 2);
-+}
-+
- #noVNC_setting_port {
-     width: 80px;
- }
--- 
-2.39.5
-
diff --git a/debian/patches/0021-use-generated-password.patch b/debian/patches/0020-use-generated-password.patch
similarity index 98%
rename from debian/patches/0021-use-generated-password.patch
rename to debian/patches/0020-use-generated-password.patch
index d9eac1f..217aa4a 100644
--- a/debian/patches/0021-use-generated-password.patch
+++ b/debian/patches/0020-use-generated-password.patch
@@ -25,3 +25,6 @@ index 6e69fb6..35a0edf 100644
  		me.UI.reconnectPassword = password;
  		me.UI.forceSetting('path', 'api2/json' + me.baseUrl + '/vncwebsocket' + "?" + wsparams);
  
+-- 
+2.47.3
+
diff --git a/debian/patches/series b/debian/patches/series
index c2b0463..8318fd6 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -17,5 +17,4 @@
 0017-make-error-hideable.patch
 0018-show-start-button-on-not-running-vm-ct.patch
 0019-show-clipboard-button.patch
-0020-Fix-appearance-of-extra-key-buttons.patch
-0021-use-generated-password.patch
+0020-use-generated-password.patch
diff --git a/novnc b/novnc
index a8dfd6a..63107bd 160000
--- a/novnc
+++ b/novnc
@@ -1 +1 @@
-Subproject commit a8dfd6a3ea3c74244f5ebdaa5a7f1023007a7820
+Subproject commit 63107bd06d9e1f6136ff21aeda8cd62cbf0d433e
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH novnc] upgrade noVNC and patches to 1.7.0
  2026-05-07  7:25 [PATCH novnc] upgrade noVNC and patches to 1.7.0 Dominik Csapak
@ 2026-05-07  9:55 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-07  9:55 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Thu, 07 May 2026 09:25:49 +0200, Dominik Csapak wrote:
> drop the backport of
>  f0a39cd (Fix appearance of extra key buttons)
> since it's included now.
> 
> and refresh/rebase the patches (including some light whitespace fixes).
> 
> 
> [...]

Applied, thanks!

[1/1] upgrade noVNC and patches to 1.7.0
      commit: 002ddce6a16fe05a15a30e70f170dc3e2ddcf7bc




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-07  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07  7:25 [PATCH novnc] upgrade noVNC and patches to 1.7.0 Dominik Csapak
2026-05-07  9:55 ` applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal