all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] sdn: controller: allow creating bgp controller without route-maps
Date: Wed,  6 May 2026 12:22:58 +0200	[thread overview]
Message-ID: <20260506102301.220990-1-g.goller@proxmox.com> (raw)

When creating a bgp controller and not supplying any route-maps you get
an error because we always add the delete property on empty.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 www/manager6/sdn/controllers/BgpEdit.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js
index 055378839fd4..08a21d1ab838 100644
--- a/www/manager6/sdn/controllers/BgpEdit.js
+++ b/www/manager6/sdn/controllers/BgpEdit.js
@@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-in',
                 fieldLabel: gettext('incoming Route Map'),
-                deleteEmpty: true,
+                deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
             },
             {
                 xtype: 'pveSDNRouteMapSelector',
                 name: 'route-map-out',
                 fieldLabel: gettext('outgoing Route Map'),
-                deleteEmpty: true,
+                deleteEmpty: !me.isCreate,
                 skipEmptyText: true,
             },
         ];
-- 
2.47.3





                 reply	other threads:[~2026-05-06 10:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260506102301.220990-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal