From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BA6421FF13B for ; Wed, 06 May 2026 12:23:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0AA381CE2C; Wed, 6 May 2026 12:23:09 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH manager] sdn: controller: allow creating bgp controller without route-maps Date: Wed, 6 May 2026 12:22:58 +0200 Message-ID: <20260506102301.220990-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778062877598 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IEKVXFP3YCSR77DSVVZ5GKANT5SJIOY4 X-Message-ID-Hash: IEKVXFP3YCSR77DSVVZ5GKANT5SJIOY4 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When creating a bgp controller and not supplying any route-maps you get an error because we always add the delete property on empty. Signed-off-by: Gabriel Goller --- www/manager6/sdn/controllers/BgpEdit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/sdn/controllers/BgpEdit.js b/www/manager6/sdn/controllers/BgpEdit.js index 055378839fd4..08a21d1ab838 100644 --- a/www/manager6/sdn/controllers/BgpEdit.js +++ b/www/manager6/sdn/controllers/BgpEdit.js @@ -77,14 +77,14 @@ Ext.define('PVE.sdn.controllers.BgpInputPanel', { xtype: 'pveSDNRouteMapSelector', name: 'route-map-in', fieldLabel: gettext('incoming Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, { xtype: 'pveSDNRouteMapSelector', name: 'route-map-out', fieldLabel: gettext('outgoing Route Map'), - deleteEmpty: true, + deleteEmpty: !me.isCreate, skipEmptyText: true, }, ]; -- 2.47.3