From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v4 0/5] client: repository: add individual component parameters
Date: Fri, 10 Apr 2026 16:09:01 +0200 [thread overview]
Message-ID: <20260410154327.4133440-1-t.lamprecht@proxmox.com> (raw)
Follow-up to [v3], reworked based on Wolfgang's and Christian's review
feedback - thx!
The compact repository URL format ([[auth-id@]server[:port]:]datastore)
can be cumbersome to work with when changing a single aspect of the
connection or when using API tokens. This series adds --server, --port,
--datastore, --auth-id, and --ns as separate CLI parameters alongside
the existing compound --repository URL.
Changes since [v3]:
- Deduplicated mutual-exclusion check into check_mutual_exclusion()
- Used AllOfSchema for mount.rs raw ApiMethod definitions
- Commands where --ns is irrelevant (login, logout, version, status, GC,
benchmark, task) now use BackupRepositoryArgs only
- Moved optional_ns_param() to pbs-client tools as shared helper
- Fixed change_backup_owner not stripping atom fields before forwarding
- Small nits (anyhow::bail! -> bail!, private ENV_VAR_PBS_NAMESPACE)
Changes since [v2]:
- Deduplicated param resolution cascade into shared helper
- Split into BackupRepositoryArgs and BackupTargetArgs (repo + ns)
Changes since [v1]:
- Split single commit into five
- CLI atoms now merge with PBS_* env vars per-field (CLI wins)
- Fixed mutual-exclusion error swallowing and duplicate ns property
- PBS_NAMESPACE works uniformly across all three client binaries
[v3]: https://lore.proxmox.com/pbs-devel/20260401225305.4069441-1-t.lamprecht@proxmox.com/
[v2]: https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/
[v1]: https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/
Thomas Lamprecht (5):
client: repository: add tests for BackupRepository parsing
client: repository: add individual component parameters
client: migrate commands to flattened repository args
docs: document repository component options and env vars
fix #5340: client: repository: add PBS_NAMESPACE environment variable
docs/backup-client.rst | 64 +++++
pbs-client/src/backup_repo.rs | 324 ++++++++++++++++++++++++-
pbs-client/src/tools/mod.rs | 291 +++++++++++++++++++---
proxmox-backup-client/src/benchmark.rs | 8 +-
proxmox-backup-client/src/catalog.rs | 26 +-
proxmox-backup-client/src/group.rs | 14 +-
proxmox-backup-client/src/main.rs | 104 ++++----
proxmox-backup-client/src/mount.rs | 130 +++++-----
proxmox-backup-client/src/namespace.rs | 33 +--
proxmox-backup-client/src/snapshot.rs | 84 ++-----
proxmox-backup-client/src/task.rs | 20 +-
proxmox-file-restore/src/main.rs | 30 +--
src/bin/proxmox_backup_debug/diff.rs | 17 +-
13 files changed, 833 insertions(+), 312 deletions(-)
--
2.47.3
next reply other threads:[~2026-04-10 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 14:09 Thomas Lamprecht [this message]
2026-04-10 14:09 ` [PATCH v4 1/5] client: repository: add tests for BackupRepository parsing Thomas Lamprecht
2026-04-10 14:09 ` [PATCH v4 2/5] client: repository: add individual component parameters Thomas Lamprecht
2026-04-10 14:09 ` [PATCH v4 3/5] client: migrate commands to flattened repository args Thomas Lamprecht
2026-04-10 14:09 ` [PATCH v4 4/5] docs: document repository component options and env vars Thomas Lamprecht
2026-04-10 14:09 ` [PATCH v4 5/5] fix #5340: client: repository: add PBS_NAMESPACE environment variable Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410154327.4133440-1-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.