all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{-backup,-mail-forward} 0/5] forward mails through notification worker; PDM compatibility
Date: Thu,  9 Apr 2026 15:27:16 +0200	[thread overview]
Message-ID: <20260409132721.272178-1-l.wagner@proxmox.com> (raw)

Forwarding through the worker has a couple of benefits:
  - We don't need to bump proxmx-mail-forwarder for changes in proxmox-notify (at
    least as soon as PVE uses a similar approach as well)
  - any notification state (history, tokens) becomes easier to reason
    about if there is only one process touching it
  - we can move the Context trait implementations from proxmox_notify to the
    actual product code again

Technically we'd need a versioned break between proxmox-backup and
proxmox-mail-forward, due to the 'mail-forwarder' feature that was not enabled in PBS
before, as well as the changed spool directory. If proxmox-mail-forward is
updated without updating proxmox-backup, forwarding the mail would fail due to

  - /var/lib/proxmox-backup/notifications/queue not existing
  - proxmox-backup not being able to deserialize notifications of the 'Forwarded Mail' kind

I don't think there is a way around this breakage, but we *could* defuse it by:

  - keep sending the old way (by directly calling into proxmox_notify)
  - but still change PBS to enable the 'mail-forwarder' feature and use the new spool-dir path
  - at some point in the future we switch proxmox-mail-forward to use the
    queue-based/worker approach, making it less likely that someone still
    holds back a proxmox-backup update, which would break forwarding

I'll leave this decision to the PBS maintainers, just tell me which approach is
preferrable, then I'll adapt the series if needed.


proxmox-backup:

Lukas Wagner (2):
  notifications: move spool directory to
    /var/lib/proxmox-backup/notifications/queue
  pull in 'mail-forwarder' feature for proxmox-notify

 Cargo.toml                      |  2 +-
 src/server/notifications/mod.rs | 30 ++++++++++++++++++++++++------
 2 files changed, 25 insertions(+), 7 deletions(-)


proxmox-mail-forward:

Lukas Wagner (3):
  forward using PBS' notification worker
  forward mails on PDM installations as well
  only ever forward for one product, favoring PVE over PBS over PDM

 Cargo.toml  |   3 +-
 src/main.rs | 129 +++++++++++++++++++++++++++++-----------------------
 2 files changed, 74 insertions(+), 58 deletions(-)


Summary over all repositories:
  4 files changed, 99 insertions(+), 65 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-04-09 13:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 13:27 Lukas Wagner [this message]
2026-04-09 13:27 ` [PATCH proxmox-backup 1/5] notifications: move spool directory to /var/lib/proxmox-backup/notifications/queue Lukas Wagner
2026-04-09 14:52   ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-backup 2/5] pull in 'mail-forwarder' feature for proxmox-notify Lukas Wagner
2026-04-09 14:54   ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 3/5] forward using PBS' notification worker Lukas Wagner
2026-04-09 15:03   ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 4/5] forward mails on PDM installations as well Lukas Wagner
2026-04-09 15:06   ` Arthur Bied-Charreton
2026-04-09 13:27 ` [PATCH proxmox-mail-forward 5/5] only ever forward for one product, favoring PVE over PBS over PDM Lukas Wagner
2026-04-09 15:15   ` Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260409132721.272178-1-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal