all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager v4 3/5] server: api: add contact schema for ACME account update endpoint
Date: Wed,  1 Apr 2026 16:21:41 +0200	[thread overview]
Message-ID: <20260401142143.309509-4-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260401142143.309509-1-s.shaji@proxmox.com>

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 changes since v3: No changes

 server/src/api/config/acme.rs | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/server/src/api/config/acme.rs b/server/src/api/config/acme.rs
index cd85ef4..6055ff8 100644
--- a/server/src/api/config/acme.rs
+++ b/server/src/api/config/acme.rs
@@ -1,6 +1,6 @@
 use anyhow::{Context, Error};
 
-use pdm_api_types::acme::AcmeRegistrationParams;
+use pdm_api_types::acme::{AcmeRegistrationParams, ACME_CONTACT_LIST_SCHEMA};
 use proxmox_router::list_subdirs_api_method;
 use proxmox_router::{Router, RpcEnvironment, SubdirMap};
 
@@ -169,7 +169,7 @@ pub async fn get_account(name: AcmeAccountName) -> Result<AccountInfo, Error> {
         properties: {
             name: { type: AcmeAccountName },
             contact: {
-                description: "List of email addresses.",
+                schema: ACME_CONTACT_LIST_SCHEMA,
                 optional: true,
             },
         },
@@ -185,7 +185,6 @@ pub async fn get_account(name: AcmeAccountName) -> Result<AccountInfo, Error> {
 /// Update an ACME account.
 pub fn update_account(
     name: AcmeAccountName,
-    // Todo: email & email-list schema
     contact: Option<String>,
     rpcenv: &mut dyn RpcEnvironment,
 ) -> Result<String, Error> {
-- 
2.47.3





  parent reply	other threads:[~2026-04-01 14:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:21 [PATCH datacenter-manager v4 0/5] fix #7179: expose ACME commands inside admin CLI Shan Shaji
2026-04-01 14:21 ` [PATCH datacenter-manager v4 1/5] cli: admin: initialize worker tasks before calling acme API methods Shan Shaji
2026-04-01 14:21 ` [PATCH datacenter-manager v4 2/5] api: acme: define API type for ACME registration parameters Shan Shaji
2026-04-01 14:21 ` Shan Shaji [this message]
2026-04-01 14:21 ` [PATCH datacenter-manager v4 4/5] fix #7179: cli: admin: add commands to manage ACME settings Shan Shaji
2026-04-01 14:21 ` [PATCH datacenter-manager v4 5/5] chore: update proxmox-acme version to 1 Shan Shaji
2026-04-02 12:04 ` applied: [PATCH datacenter-manager v4 0/5] fix #7179: expose ACME commands inside admin CLI Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401142143.309509-4-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal