all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 2/3] api: backup: drop legacy starttime and dow from API response
Date: Wed,  1 Apr 2026 16:09:01 +0200	[thread overview]
Message-ID: <20260401140903.364176-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260401140903.364176-1-l.wagner@proxmox.com>

We dropped it from the schema, so it makes sense to drop it from the
actual response as well.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 PVE/API2/Backup.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 2ab78834..0683748e 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -213,6 +213,8 @@ __PACKAGE__->register_method({
         my $res = $data->{jobs} || [];
         foreach my $job (@$res) {
             $job->{schedule} = $convert_to_schedule->($job);
+            delete $job->{starttime};
+            delete $job->{dow};
         }
 
         foreach my $jobid (sort { $order->{$a} <=> $order->{$b} } keys %$jobs) {
@@ -381,6 +383,9 @@ __PACKAGE__->register_method({
         foreach my $job (@$jobs) {
             if ($job->{id} eq $param->{id}) {
                 $job->{schedule} = $convert_to_schedule->($job);
+                delete $job->{starttime};
+                delete $job->{dow};
+
                 return $job;
             }
         }
-- 
2.47.3





  parent reply	other threads:[~2026-04-01 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:08 [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Lukas Wagner
2026-04-01 14:09 ` [PATCH manager 1/3] api: backup: drop starttime and dow from return schema Lukas Wagner
2026-04-01 14:09 ` Lukas Wagner [this message]
2026-04-01 14:09 ` [PATCH manager 3/3] api: backup: deprecate starttime and dow in create/update parameter schema Lukas Wagner
2026-04-02 16:11 ` applied: [PATCH manager 0/3] api: backup: drop/deprecate dow and starttime Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401140903.364176-3-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal