From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 1/3] api: disk reassign: use target disk key and 'reassign' in log message
Date: Wed, 1 Apr 2026 11:51:58 +0200 [thread overview]
Message-ID: <20260401095213.127495-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260401095213.127495-1-f.ebner@proxmox.com>
The target disk key is useful information. The word 'reassign' matches
how the operation is called in the UI and better distinguishes it from
the disk move between storages.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/API2/Qemu.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 020c68b2..09f88ae1 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -4987,7 +4987,8 @@ __PACKAGE__->register_method({
my $source_volid = $drive->{file};
- print "moving disk '$disk' from VM '$vmid' to '$target_vmid'\n";
+ print("reassign disk '$disk' from VM '$vmid' as '$target_disk' to"
+ . " VM '$target_vmid'\n");
my ($storeid, $source_volname) =
PVE::Storage::parse_volume_id($source_volid);
--
2.47.3
next prev parent reply other threads:[~2026-04-01 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 9:51 [PATCH-SERIES qemu-server 0/3] api: disk clone/move/reassign: log more core operations Fiona Ebner
2026-04-01 9:51 ` Fiona Ebner [this message]
2026-04-01 9:51 ` [PATCH qemu-server 2/3] api: disk move: print description of core operations to task log Fiona Ebner
2026-04-01 9:52 ` [PATCH qemu-server 3/3] clone disk: log target volume ID after allocating Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401095213.127495-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.