[PATCH storage v2 3/7] lvm plugin: rename: update tags when renaming

[Fiona Ebner <f.ebner@proxmox.com>]

The rename_volume() function is used when reassigning a volume to a
different VM. When a volume is created, a tag 'pve-vm-ID' with the VM
ID is added to the volume, and for qcow2, additionally a tag with the
volume name. Replace the tag(s) with one(s) for the new VM ID (and new
volume name for qcow2) after renaming to keep them consistent.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 src/PVE/Storage/LVMPlugin.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 8392c89..cd4d07a 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1454,6 +1454,18 @@ sub rename_volume {
         if ($lvs->{$vg}->{$target_volname});
 
     lvrename($scfg, $source_volname, $target_volname);
+
+    eval {
+        my $tag_opts =
+            ['--addtag', "pve-vm-${target_vmid}", '--deltag', "pve-vm-${source_vmid}"];
+        if ($format eq 'qcow2') {
+            push $tag_opts->@*, '--addtag', "pve-$target_volname";
+            push $tag_opts->@*, '--deltag', "pve-$source_volname";
+        }
+        run_command(['lvchange', $tag_opts->@*, "${vg}/${target_volname}"]);
+    };
+    warn "unable to update tags for '$target_volname' - $@" if $@;
+
     return "${storeid}:${target_volname}";
 }
 
-- 
2.47.3