From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage v2 2/7] lvm plugin: rename: improve error message
Date: Tue, 31 Mar 2026 13:49:50 +0200 [thread overview]
Message-ID: <20260331115011.102276-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com>
Avoid the use of 'we', mention the volume in question and add a
newline.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
No changes in v2.
src/PVE/Storage/LVMPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index f9349de..8392c89 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1441,7 +1441,8 @@ sub rename_volume {
if ($format eq 'qcow2') {
$class->activate_volume($storeid, $scfg, $source_volname);
my $snapshots = $class->volume_snapshot_info($scfg, $storeid, $source_volname);
- die "we can't rename volume if external snapshot exists" if $snapshots->{current}->{parent};
+ die "can't rename volume '$source_volname' - external snapshot exists\n"
+ if $snapshots->{current}->{parent};
}
$target_volname = $class->find_free_diskname($storeid, $scfg, $target_vmid, $format)
--
2.47.3
next prev parent reply other threads:[~2026-03-31 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 11:49 [PATCH-SERIES storage v2 0/7] lvm plugin: activation/renaming/tag improvements Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 1/7] fix #7280: lvm plugin: rename: activate qcow2 volume to read snapshot info Fiona Ebner
2026-03-31 11:49 ` Fiona Ebner [this message]
2026-03-31 11:49 ` [PATCH storage v2 3/7] lvm plugin: rename: update tags when renaming Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 4/7] lvm plugin: remove cryptic partial comment Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 5/7] lvm plugin: activation: avoid extra variable Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 6/7] fix #7143: ensure qcow2 volume (de)activation is limited to target volume chain Fiona Ebner
2026-03-31 11:49 ` [PATCH storage v2 7/7] lvm plugin: schema: align description of 'tagged_only' with actual behavior Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331115011.102276-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.