From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH v2 manager 1/1] ceph: init: clean up deprecated pg_bits parameter
Date: Sat, 28 Mar 2026 19:23:07 +0800 [thread overview]
Message-ID: <20260328112307.1131390-2-k.chai@proxmox.com> (raw)
In-Reply-To: <20260328112307.1131390-1-k.chai@proxmox.com>
The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
from Ceph in v13.0.2. It has been a guaranteed no-op on every cluster
PVE 9 can manage.
Removing the API parameter itself would be a breaking change during the
9.x release cycle, so keep it as a documented no-op until PVE 10. Only
remove the dead-code comments that referenced it in the implementation,
and fix the typos in the TODO and description.
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
PVE/API2/Ceph.pm | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 231b751c..bf8cd5bb 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -161,11 +161,11 @@ __PACKAGE__->register_method({
minimum => 1,
maximum => 7,
},
- # TODO: deprecrated, remove with PVE 9
+ # TODO: deprecated, remove with PVE 10
pg_bits => {
description => "Placement group bits, used to specify the "
- . "default number of placement groups.\n\nDepreacted. This "
- . "setting was deprecated in recent Ceph versions.",
+ . "default number of placement groups.\n\nDeprecated. This "
+ . "setting has been ignored since Ceph Nautilus.",
type => 'integer',
default => 6,
optional => 1,
@@ -238,9 +238,6 @@ __PACKAGE__->register_method({
'mon_allow_pool_delete' => 'true',
};
- # this does not work for default pools
- #'osd pool default pg num' => $pg_num,
- #'osd pool default pgp num' => $pg_num,
}
if ($auth eq 'cephx') {
--
2.47.3
prev parent reply other threads:[~2026-03-28 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 11:23 [PATCH v2 manager 0/1] " Kefu Chai
2026-03-28 11:23 ` Kefu Chai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328112307.1131390-2-k.chai@proxmox.com \
--to=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.