From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: David Riley <d.riley@proxmox.com>
Subject: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid
Date: Fri, 27 Mar 2026 11:38:00 +0100 [thread overview]
Message-ID: <20260327103801.104735-1-d.riley@proxmox.com> (raw)
This v2 implements the suggested stop-gap solution for filtering the
virtual guest selection in the backup job edit window.
Differences from v1:
- Drop the complex collapsible filter panel (tags, pools, HA State)
This avoids the UX trap of users thinking the filters apply
dynamically at job runtime (deferring that feature for a proper
implementation of #4186 [0]).
- Add search text-field in the grid toolbar to filter by
Name or VMID.
- Add a "Review" toggle checkbox in the bottom toolbar that limits
the grid view to only currently selected guests.
- Add a "Selected (X)" counter in the bottom toolbar for immediate
visual feedback.
- Override the `getValue` collection logic to gather data directly
from the SelectionModel, ensuring virtual guests hidden by the
Search filter are still correctly submitted.
Thanks for testing and reviewing my last patch.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4186
David Riley (1):
fix: #4490 ui: backup job window: add search for virtual guest grid
www/manager6/dc/Backup.js | 167 +++++++++++++++++++++++++++++++++++++-
1 file changed, 166 insertions(+), 1 deletion(-)
--
2.47.3
next reply other threads:[~2026-03-27 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 10:38 David Riley [this message]
2026-03-27 10:38 ` [PATCH pve-manager v2 1/1] " David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327103801.104735-1-d.riley@proxmox.com \
--to=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.