From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 1/2] backup: vma: add context to error message upon backup start
Date: Thu, 26 Mar 2026 12:31:41 +0100 [thread overview]
Message-ID: <20260326113251.68540-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260326113251.68540-1-f.ebner@proxmox.com>
Upon failure, the queue_execute() function returns the error message
from QEMU directly:
> INFO: issuing guest-agent 'fs-freeze' command
> INFO: issuing guest-agent 'fs-thaw' command
> ERROR: <error message from QEMU>
Many such error messages mention internal QEMU functions and can be
hard to interpret without knowledge of QEMU.
Add some context to the error message to improve this:
> INFO: issuing guest-agent 'fs-freeze' command
> INFO: issuing guest-agent 'fs-thaw' command
> ERROR: executing QMP command to start backup failed - <error message from QEMU>
In case of PBS and provider-based backups, mon_cmd() is used, which
already includes the information which failed QMP command it is, for
example, for PBS:
> ERROR: VM 100 qmp command 'backup' failed - <error message from QEMU>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/VZDump/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm
index 0681661d..2d55fbfa 100644
--- a/src/PVE/VZDump/QemuServer.pm
+++ b/src/PVE/VZDump/QemuServer.pm
@@ -1031,7 +1031,7 @@ sub archive_vma {
$self->qga_fs_thaw($vmid);
}
- die $qmperr if $qmperr;
+ die "executing QMP command to start backup failed - $qmperr" if $qmperr;
die $qmpclient->{errors}->{$vmid} if $qmpclient->{errors}->{$vmid};
if ($cpid) {
--
2.47.3
next prev parent reply other threads:[~2026-03-26 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 11:31 [PATCH-SERIES qemu-server 0/2] backup: improve logging " Fiona Ebner
2026-03-26 11:31 ` Fiona Ebner [this message]
2026-03-26 11:31 ` [PATCH qemu-server 2/2] backup: log backup start via QMP command to avoid confusion about freeze/thaw Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326113251.68540-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.