* [PATCH yew-comp] auth view: don't mark realm sync dialog as "edit" and set submit text
@ 2026-03-25 11:43 Shannon Sterz
0 siblings, 0 replies; only message in thread
From: Shannon Sterz @ 2026-03-25 11:43 UTC (permalink / raw)
To: yew-devel
previously it was not possible to submit this window without making
any changes since setting a loader marked the window as being in "edit
mode". leading to the paradoxical scenario where running a sync job
with the default settings for that realm wasn't possible.
change this behaviour by marking the `EditWindow` as not being in
"edit mode" and setting a more appropriate text for the submit button.
the side-effect of this is that the reset button is no longer
available, but that is deemed preferable over not being able to sync
with a realm's default configuration.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
Notes:
it might be preferable to split up behaviour here. maybe whether the
reset button is rendered and "check_dirty" is enabled on the submit
button should be separate settings. but that would have had wider
implications across our ecosystem, so i opted for this smaller set of
changes here.
src/auth_view.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/auth_view.rs b/src/auth_view.rs
index 7a88f4c..9a06979 100644
--- a/src/auth_view.rs
+++ b/src/auth_view.rs
@@ -469,6 +469,8 @@ impl LoadableComponent for ProxmoxAuthView {
format!("{base_url}/{}", percent_encode_component(&realm.realm));
move || load_realm(url.clone())
})
+ .edit(false)
+ .submit_text(tr!("Start Sync"))
.submit_digest(false)
.on_close(link.change_view_callback(|_| None))
.on_submit(move |form_context| {
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-03-25 11:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-25 11:43 [PATCH yew-comp] auth view: don't mark realm sync dialog as "edit" and set submit text Shannon Sterz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.