all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ceph: init: drop deprecated pg_bits parameter
Date: Wed, 25 Mar 2026 12:31:20 +0800	[thread overview]
Message-ID: <20260325043120.2289935-1-k.chai@proxmox.com> (raw)

The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
from Ceph in v13.0.2.  The implementation was made a no-op at that point,
with a TODO to remove the parameter declaration in PVE 9.

We are now at pve-manager 9.1.6.  The minimum Ceph version supported by
pveceph init is Nautilus (v14), which is already past the point where
these options existed, so the parameter has been a guaranteed no-op on
every cluster PVE 9 can manage.  Remove it along with the adjacent
dead-code comments.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/API2/Ceph.pm | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 231b751c..f59caf16 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -161,17 +161,6 @@ __PACKAGE__->register_method({
                 minimum => 1,
                 maximum => 7,
             },
-            # TODO: deprecrated, remove with PVE 9
-            pg_bits => {
-                description => "Placement group bits, used to specify the "
-                    . "default number of placement groups.\n\nDepreacted. This "
-                    . "setting was deprecated in recent Ceph versions.",
-                type => 'integer',
-                default => 6,
-                optional => 1,
-                minimum => 6,
-                maximum => 14,
-            },
             disable_cephx => {
                 description => "Disable cephx authentication.\n\n"
                     . "WARNING: cephx is a security feature protecting against "
@@ -238,9 +227,6 @@ __PACKAGE__->register_method({
                         'mon_allow_pool_delete' => 'true',
                     };
 
-                    # this does not work for default pools
-                    #'osd pool default pg num' => $pg_num,
-                    #'osd pool default pgp num' => $pg_num,
                 }
 
                 if ($auth eq 'cephx') {
-- 
2.47.3





             reply	other threads:[~2026-03-25  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  4:31 Kefu Chai [this message]
2026-03-26 11:45 ` Maximiliano Sandoval
2026-03-26 12:55 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325043120.2289935-1-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal