all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager 0/2] fix param check for rules updates and
Date: Tue, 24 Mar 2026 13:49:19 +0100	[thread overview]
Message-ID: <20260324124921.148515-1-m.koeppl@proxmox.com> (raw)

This series fixes the PUT API endpoint for updating a HA rule.
Previously, it would fail if the resources parameter was not set at all
as part of the request, even though the param is optional As part of an
E2E test run, the error showed up as

    500 update HA rules failed: Can't use an undefined value as a HASH
    reference at /usr/share/perl5/PVE/API2/HA/Rules.pm line 48.

In addition, 2/2 fixes wrong formatting introduced by a recent commit.

pve-ha-manager:

Michael Köppl (2):
  api: assert validity of resources param only if defined
  format code with perltidy

 src/PVE/API2/HA/Rules.pm   | 2 +-
 src/PVE/HA/Usage/Static.pm | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)


Summary over all repositories:
  2 files changed, 5 insertions(+), 3 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-03-24 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 12:49 Michael Köppl [this message]
2026-03-24 12:49 ` [PATCH ha-manager 1/2] api: assert validity of resources param only if defined Michael Köppl
2026-03-24 12:49 ` [PATCH ha-manager 2/2] format code with perltidy Michael Köppl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260324124921.148515-1-m.koeppl@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal