From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 3/4] cpu config: get cpu options: avoid shadowing $conf variable
Date: Mon, 23 Mar 2026 14:27:23 +0100 [thread overview]
Message-ID: <20260323132857.125747-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260323132857.125747-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QemuServer/CPUConfig.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm
index c689efad..8da9010e 100644
--- a/src/PVE/QemuServer/CPUConfig.pm
+++ b/src/PVE/QemuServer/CPUConfig.pm
@@ -975,9 +975,9 @@ sub get_cpu_options {
for my $phys_bits_opt (qw(guest-phys-bits phys-bits)) {
my $phys_bits = '';
- foreach my $conf ($custom_cpu, $cpu) {
- next if !defined($conf);
- my $conf_val = $conf->{$phys_bits_opt};
+ for my $cpu_conf ($custom_cpu, $cpu) {
+ next if !defined($cpu_conf);
+ my $conf_val = $cpu_conf->{$phys_bits_opt};
next if !$conf_val;
if ($conf_val eq 'host') {
die "unexpected value 'host' for guest-phys-bits"
--
2.47.3
next prev parent reply other threads:[~2026-03-23 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 13:27 [PATCH-SERIES qemu-server 0/4] cpu config: warn that OVMF might limit phys-bits to 40 without pdpe1gb CPU flag Fiona Ebner
2026-03-23 13:27 ` [PATCH qemu-server 1/4] cpu config: split resolve_cpu_flags() function Fiona Ebner
2026-03-23 13:27 ` [PATCH qemu-server 2/4] move get_host_phys_address_bits() to helpers module Fiona Ebner
2026-03-23 13:27 ` Fiona Ebner [this message]
2026-03-23 13:27 ` [PATCH qemu-server 4/4] cpu config: warn that OVMF might limit phys-bits to 40 without pdpe1gb CPU flag Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323132857.125747-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.